I assume it has been this way for some time as neither package has changed. I assume I did not have the upnp use flag set in the past and not sure why I do now. But it fails every time. Reinstalling net-libs/miniupnpc-1.9.20151008 did not make any difference. net-libs/miniupnpc Likely needs to be updated to newer 1.9 or 2.0. In file included from /usr/include/sys/param.h:23:0, from have.h:90, from system.h:26, from upnp.h:23, from upnp.c:20: upnp.c: In function ‘upnp_discover’: upnp.c:60:29: error: called object is not a function or function pointer return upnpDiscover(delay, NULL NULL, false, false, 2, error); ^ upnp.c:60:57: warning: passing argument 6 of ‘upnpDiscover’ makes integer from pointer without a cast [-Wint-conversion] return upnpDiscover(delay, NULL NULL, false, false, 2, error); ^ In file included from upnp.c:24:0: /usr/include/miniupnpc/miniupnpc.h:62:1: note: expected ‘unsigned char’ but argument is of type ‘int *’ upnpDiscover(int delay, const char * multicastif, ^ upnp.c:60:9: error: too few arguments to function ‘upnpDiscover’ return upnpDiscover(delay, NULL NULL, false, false, 2, error); ^ In file included from upnp.c:24:0: /usr/include/miniupnpc/miniupnpc.h:62:1: note: declared here upnpDiscover(int delay, const char * multicastif, ^ make[2]: *** [Makefile:986: upnp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/tmp/portage/net-misc/tinc-1.1_pre14/work/tinc-1.1pre14/src' make[1]: *** [Makefile:376: all-recursive] Error 1 make[1]: Leaving directory '/tmp/portage/net-misc/tinc-1.1_pre14/work/tinc-1.1pre14' make: *** [Makefile:317: all] Error 2
Please attach full build.log, 'emerge --info' output and 'emerge -pqv net-misc/tinc' output.
this bug was introduced by miniupnp upstream while update api to 14 [1], so use <=miniupnpc-1.9.20150427 should work around this problem. on the other side, we may check with tinc upstream to see if they willing to move forward. thanks for reporting this. [1] https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9
as tested, I have no problem with <=miniupnpc-1.9.20150427, but do have issue with >=miniupnpc-1.9.20150917-r1 AFAIS, the tinc upstream already cover all miniupnpc APIs (including API=14 ) [1] and I found it's difficult to trace miniupnpc, I can't match the tarball source to the exact upstream commit version, so I'm just leaving/CCing to the miniupnpc maintainer so I'll go the simple way, restrict the dependency, make sure tinc using <=miniupnpc-1.9.20150427 [1] https://tinc-vpn.org/git/browse?p=tinc;a=blobdiff;f=src/upnp.c;h=abd2f92fa9eb791a33e5c580a03e2e3f44965e08;hp=a03143a12deac3d425d48f9bf460249680010e1c;hb=0f6d34dc1b43edc6f5bea45c17ce2d6a417265f1;hpb=675e3b497bdc87f5a4dfdef7508cd2070850e69e
sorry for the noise.. it takes me a while to figure out that there is a comma missing in tinc code, fixed/pushed without revision bump, thanks https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d5cfa648619324bf830739e69bab087449a8f56
