Created attachment 447494 [details] build.log.xz Running test 61 Running test 62 ./test: line 186: warning: command substitution: ignored null byte in input ./test: line 186: warning: command substitution: ignored null byte in input ... The last line is repeated until there is no more space for the log file and emerge/python prints a backtrace: Traceback (most recent call last): File "/usr/lib/python-exec/python2.7/emerge", line 50, in <module> retval = emerge_main() File "/usr/lib64/python2.7/site-packages/_emerge/main.py", line 1185, in emerge_main return run_action(emerge_config) File "/usr/lib64/python2.7/site-packages/_emerge/actions.py", line 3236, in run_action emerge_config.args, spinner) File "/usr/lib64/python2.7/site-packages/_emerge/actions.py", line 505, in action_build retval = mergetask.merge() File "/usr/lib64/python2.7/site-packages/_emerge/Scheduler.py", line 1032, in merge rval = self._merge() File "/usr/lib64/python2.7/site-packages/_emerge/Scheduler.py", line 1434, in _merge self._main_loop() File "/usr/lib64/python2.7/site-packages/_emerge/Scheduler.py", line 1411, in _main_loop self._event_loop.iteration() File "/usr/lib64/python2.7/site-packages/portage/util/_eventloop/EventLoop.py", line 270, in iteration if not x.callback(f, event, *x.args): File "/usr/lib64/python2.7/site-packages/portage/util/_async/PipeLogger.py", line 131, in _output_handler log_file.flush() IOError: [Errno 28] No space left on device
localhost ~ # emerge --info '=app-admin/logrotate-3.10.0::gentoo' Portage 2.2.28 (python 2.7.10-final-0, default/linux/amd64/13.0, gcc-4.9.3, glibc-2.22-r4, 4.4.6-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.4.6-gentoo-x86_64-Intel-R-_Core-TM-_i5-2520M_CPU_@_2.50GHz-with-gentoo-2.2 KiB Mem: 4043380 total, 3544492 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Fri, 23 Sep 2016 00:45:01 +0000 sh bash 4.4 ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1 app-shells/bash: 4.4::gentoo dev-lang/perl: 5.22.2::gentoo dev-lang/python: 2.7.10-r1::gentoo, 3.4.3-r1::gentoo dev-util/pkgconfig: 0.28-r2::gentoo sys-apps/baselayout: 2.2::gentoo sys-apps/openrc: 0.21.3::gentoo sys-apps/sandbox: 2.10-r1::gentoo sys-devel/autoconf: 2.69::gentoo sys-devel/automake: 1.14.1::gentoo, 1.15::gentoo sys-devel/binutils: 2.25.1-r1::gentoo sys-devel/gcc: 4.9.3::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6::gentoo sys-devel/make: 4.1-r1::gentoo sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers) sys-libs/glibc: 2.22-r4::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LDFLAGS="-Wl,-O1 -Wl,--as-needed" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx mmxext modules multilib ncurses nls nptl openmp pam pcre readline seccomp session sse sse2 ssl tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON localhost ~ # emerge -pqv '=app-admin/logrotate-3.10.0::gentoo' [ebuild N ] app-admin/logrotate-3.10.0 USE="acl cron (-selinux)"
Test 62 creates a 10 MB file of zeroes[1], which is later fed into checkoutput()[2]. checkoutput() reads the file contents with[3]: contents=`cat $file` which causes bash-4.4 to print the warning from comment 0 once for each byte read. Presumably this will not fail if there is 760 MB of space available for the build log, which seems rather excessive. 1: https://github.com/logrotate/logrotate/blob/3.10.0/test/test#L1580 2: https://github.com/logrotate/logrotate/blob/3.10.0/test/test#L1605 3: https://github.com/logrotate/logrotate/blob/3.10.0/test/test#L186
Should it become necessary to implement a workaround as concerns this - and related - bugs, tr is one possible solution. However, one might consider implementing a cat workalike in pure bash. uuoc() { # A useful use of cat! while true; do [[ $1 ]] && exec <"$1" while IFS= read -r; do printf '%s\n' "$REPLY" done [[ $REPLY ]] && printf %s "$REPLY" shift || break done } Thus, contents=$(<file) # can be written as contents=$(uuoc file) contents=$(cat file1 file2) # can be written as contents=$(uuoc file1 file2) contents=$(zcat file.gz) # can be written as contents=$(zcat file.gz | uuoc) ... and so forth. This function will not induce the null byte warnings.
Chet has changed bash so that, rather than emitting a warning for every NUL byte encountered, it emits - at most - one warning to STDERR per command substitution. This change was made in 4.4_p2 (4.4_p5 is available in portage) [1]. This sensible change greatly lessens the impact of both this and bug 595276 at large. Given this change, and given that the point of this warning is that processing - and allowing bash to discard - NUL bytes in a command substitution can be a code smell, I would now recommend against applying any hacks or workarounds in lieu of bug 595276, except where there is a clear and obvious intent for (expected) NUL bytes to be ignored. [1] https://lists.gnu.org/archive/html/bug-bash/2016-11/msg00069.html
I've tested last version of logrotate (3.11.0) with bash-4.4_p5-r1 and all test pass. Please check and report any issues. Thanks for the report.
No comments in months. Closing.
