594762 – net-analyzer/tcpdump should not filter CFLAGS

Bug 594762 - net-analyzer/tcpdump should not filter CFLAGS

Summary: net-analyzer/tcpdump should not filter CFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo Netmon project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-09-22 13:06 UTC by .
Modified:	2016-09-22 13:26 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description . 2016-09-22 13:06:42 UTC

ebuild code:

```
    # tcpdump needs some optimization. see bug #108391
    # but do not replace -Os
    filter-flags -O[0-9]
    has -O? ${CFLAGS} || append-cflags -O2
    
    filter-flags -finline-functions
```

- -O<n> filter comes from https://bugs.gentoo.org/show_bug.cgi?id=108391
- -finline-functions filter comes from https://bugs.gentoo.org/show_bug.cgi?id=37184

Both bugs are completely irrelevant nowadays and were probably compiler bugs with ancient GCC3.

GCC3 is still in the tree and marked stable though, so if you still want to make it compile under this version, at least make the filters conditional.

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2016-09-22 13:26:35 UTC

Removed in 4.8.0-r1.