Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 594124 - media-libs/assimp-3.3.1 version bump
Summary: media-libs/assimp-3.3.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sławek Lis (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2016-09-17 20:28 UTC by Robin Kauffman
Modified: 2016-09-21 06:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
AssImp 3.3.1 ebuild (EAPI 6) (assimp-3.3.1.ebuild,1.19 KB, text/plain)
2016-09-17 20:28 UTC, Robin Kauffman
Details
Updated patch to an AssImp CMake module (may not be necessary) (findassimp.patch,670 bytes, patch)
2016-09-17 20:30 UTC, Robin Kauffman
Details | Diff
bump to assimp-3.3.1.ebuild, removed BOOST_WORKAROUND (assimp-3.3.1.ebuild,1.12 KB, text/plain)
2016-09-17 20:35 UTC, Robin Kauffman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Kauffman 2016-09-17 20:28:12 UTC
Created attachment 446200 [details]
AssImp 3.3.1 ebuild (EAPI 6)

Version 3.3.1 of AssImp has been out for a couple of months now.  It's a bugfix on top of 3.3, which was more of a feature bump.  Renaming the ebuild seems to work.  test-cmakelists.patch seems not to apply (in both senses of the word — I cannot figure out how to shoehorn the patch's changes in manually, and it no longer seems to be necessary anyway), so it seems like it could just be dropped.  findassimp.patch needs little more than a target rename.  I "applied" the patch manually to the closest thing that matched it (which seemed to be under a WIN32 clause, so the findassimp patch may not be necessary either) and redid the patch.

Finally, I bumped the EAPI to 6 and fixed the ebuild to be EAPI-6-compliant.
Comment 1 Robin Kauffman 2016-09-17 20:30:37 UTC
Created attachment 446202 [details, diff]
Updated patch to an AssImp CMake module (may not be necessary)

Here's the patch (which may be totally unnecessary).
Comment 2 Robin Kauffman 2016-09-17 20:35:20 UTC
Created attachment 446206 [details]
bump to assimp-3.3.1.ebuild, removed BOOST_WORKAROUND

Realized that neither -DASSIMP_ENABLE_BOOST_WORKAROUND nor -DASSIMP_BUILD_BOOST_WORKAROUND are handled (or mentioned) by any of the CMake rules.  Passed the latter in initially since it was briefly mentioned in a couple of .h files, but was of course not passed through to the compiler stage, near as I could tell.  Dropped the CMake build option, the 'boost' USE flag, and the 'boost? ( )' wrapping dev-libs/boost.