Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 593902 - dev-python/pytest-3.0.2 fails test TestMockDecoration.test_wrapped_getfuncargnames_patching - AttributeError: 'str' object has no attribute 'attribute_name'
Summary: dev-python/pytest-3.0.2 fails test TestMockDecoration.test_wrapped_getfuncarg...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-15 20:27 UTC by eroen
Modified: 2019-06-02 13:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,149.25 KB, text/plain)
2016-09-15 20:27 UTC, eroen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eroen 2016-09-15 20:27:32 UTC
Created attachment 445870 [details]
build.log

As can be guessed from the snippet of num_mock_patch_args() below; this failure only happens if 'mock' module was imported by an earlier test. I can reliably reproduce it by installing the following packages:

dev-python/twisted-core-15.2.1
dev-python/extras-1.0.0
dev-python/fixtures-1.4.0
dev-python/subunit-1.2.0-r1
dev-python/testtools-2.2.0
dev-python/mock-2.0.0

The cause of the error seems clear, ["qwe"] is a list of str, and str does not have a 'attribute_name' attribute. It is somewhat unclear what was really intended here.


=================================== FAILURES ===================================
___________ TestMockDecoration.test_wrapped_getfuncargnames_patching ___________

self = <integration.TestMockDecoration instance at 0x7fe81629b3f8>

    def test_wrapped_getfuncargnames_patching(self):
        from _pytest.compat import getfuncargnames
        def wrap(f):
            def func():
                pass
            func.__wrapped__ = f
            func.patchings = ["qwe"]
            return func
        @wrap
        def f(x, y, z):
            pass
>       l = getfuncargnames(f)

testing/python/integration.py:102: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../pytest-3.0.2-python2_7/lib/_pytest/compat.py:82: in getfuncargnames
    startindex += num_mock_patch_args(function)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

function = <function func at 0x7fe8153afc08>

    def num_mock_patch_args(function):
        """ return number of arguments used up by mock arguments (if any) """
        patchings = getattr(function, "patchings", None)
        if not patchings:
            return 0
        mock = sys.modules.get("mock", sys.modules.get("unittest.mock", None))
        if mock is not None:
            return len([p for p in patchings
>                           if not p.attribute_name and p.new is mock.DEFAULT])
E           AttributeError: 'str' object has no attribute 'attribute_name'

../pytest-3.0.2-python2_7/lib/_pytest/compat.py:69: AttributeError
======= 1 failed, 1650 passed, 43 skipped, 13 xfailed in 118.81 seconds ========
 * ERROR: dev-python/pytest-3.0.2::gentoo failed (test phase):
 *   tests failed with python2.7
 * 
 * Call stack:
 *     ebuild.sh, line  133:  Called src_test
 *   environment, line 3659:  Called distutils-r1_src_test
 *   environment, line  970:  Called _distutils-r1_run_foreach_impl 'python_test'
 *   environment, line  307:  Called python_foreach_impl 'distutils-r1_run_phase' 'python_test'
 *   environment, line 3163:  Called multibuild_foreach_variant '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'python_test'
 *   environment, line 2272:  Called _multibuild_run '_python_multibuild_wrapper' 'distutils-r1_run_phase' 'python_test'
 *   environment, line 2270:  Called _python_multibuild_wrapper 'distutils-r1_run_phase' 'python_test'
 *   environment, line  578:  Called distutils-r1_run_phase 'python_test'
 *   environment, line  902:  Called python_test
 *   environment, line 3537:  Called die
 * The specific snippet of code:
 *           "${PYTHON}" "${BUILD_DIR}"/lib/pytest.py -v testing || die "tests failed with ${EPYTHON}";
Comment 1 eroen 2016-09-15 20:33:23 UTC
localhost ~ # emerge --info '=dev-python/pytest-3.0.2::gentoo'
Portage 2.2.28 (python 3.4.3-final-0, default/linux/amd64/13.0, gcc-4.9.3, glibc-2.22-r4, 4.4.6-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.4.6-gentoo-x86_64-Intel-R-_Core-TM-_i5-2520M_CPU_@_2.50GHz-with-gentoo-2.2
KiB Mem:     4043380 total,   3420100 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 15 Sep 2016 00:45:01 +0000
sh bash 4.3_p42-r1
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p42-r1::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.10-r1::gentoo, 3.4.3-r1::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.21.3::gentoo
sys-apps/sandbox:         2.10-r1::gentoo
sys-devel/autoconf:       2.69::gentoo
sys-devel/automake:       1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers)
sys-libs/glibc:           2.22-r4::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 mmx mmxext modules multilib ncurses nls nptl openmp pam pcre readline seccomp session sse sse2 ssl tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

localhost ~ # emerge -pqv '=dev-python/pytest-3.0.2::gentoo'
[ebuild  N    ] dev-python/pytest-3.0.2  USE="{test}" PYTHON_TARGETS="python2_7 python3_4 -pypy -pypy3 (-python3_3) -python3_5" 

 * IMPORTANT: 10 news items need reading for repository 'gentoo'.
 * Use eselect news read to view new items.
Comment 2 Rolf Eike Beer archtester 2017-12-15 22:45:46 UTC
Still in 3.3.2:

=============================================================================================================================== FAILURES ===============================================================================================================================
____________________________________________________________________________________________________________________________ test_something ____________________________________________________________________________________________________________________________

    def test_something():
        # pytest does not import logging
>       assert 'logging' not in sys.modules
E       AssertionError: assert 'logging' not in {'StringIO': <module 'StringIO' from '/usr/lib/python2.7/StringIO.pyc'>, 'UserDict': <module 'UserDict' from '/usr/lib...: <module '__builtin__' (built-in)>, '__future__': <module '__future__' from '/usr/lib/python2.7/__future__.pyc'>, ...}
E        +  where {'StringIO': <module 'StringIO' from '/usr/lib/python2.7/StringIO.pyc'>, 'UserDict': <module 'UserDict' from '/usr/lib...: <module '__builtin__' (built-in)>, '__future__': <module '__future__' from '/usr/lib/python2.7/__future__.pyc'>, ...} = sys.modules

test_logging_initialized_in_test.py:4: AssertionError
======================================================================================================================= 1 failed in 0.39 seconds =======================================================================================================================
_______________________________________________________________________________________________________ TestMockDecoration.test_wrapped_getfuncargnames_patching _______________________________________________________________________________________________________

self = <integration.TestMockDecoration object at 0xf14c34b0>

    def test_wrapped_getfuncargnames_patching(self):
        from _pytest.compat import getfuncargnames

        def wrap(f):
            def func():
                pass
            func.__wrapped__ = f
            func.patchings = ["qwe"]
            return func

        @wrap
        def f(x, y, z):
            pass

>       l = getfuncargnames(f)

testing/python/integration.py:113:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../pytest-3.2.2-python2_7/lib/_pytest/compat.py:103: in getfuncargnames
    startindex += num_mock_patch_args(function)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

function = <function func at 0xf14d01b0>

    def num_mock_patch_args(function):
        """ return number of arguments used up by mock arguments (if any) """
        patchings = getattr(function, "patchings", None)
        if not patchings:
            return 0
        mock = sys.modules.get("mock", sys.modules.get("unittest.mock", None))
        if mock is not None:
            return len([p for p in patchings
>                       if not p.attribute_name and p.new is mock.DEFAULT])
E           AttributeError: 'str' object has no attribute 'attribute_name'

../pytest-3.2.2-python2_7/lib/_pytest/compat.py:82: AttributeError
=================================================================================================== 2 failed, 1848 passed, 31 skipped, 13 xfailed in 1746.77 seconds ===================================================================================================
Comment 3 Virgil Dupras (RETIRED) gentoo-dev 2019-01-29 14:36:01 UTC
I can reproduce the failure by installing the packages eroen mentions and running tests on 3.2.2 (py36).

On pytest 3.4.2, I get failures, but not the same ones, those onces are related to xdist.

Same on 3.10.1 and 4.1.1.

So, in short, I think that the original problem was fixed upstream but that we still can't run pytest's xdist-related tests.
Comment 4 Virgil Dupras (RETIRED) gentoo-dev 2019-06-02 13:31:22 UTC
With the newly bumped pytest-xdist 1.28.0, all tests pass even with packages mentioned in this bug's first comment. I'd say we can consider this bug fixed.