Bug 593836 – www-client:chromium-55.0.2859.0[-system-ffmpeg] yasm error

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Gilbert 2016-09-15 01:04:58 UTC]

It looks like whatever script generates autorename_libavcodec_x86_sbrdsp.asm is inserting a C++ style comment (//). yasm does not like that.

> FAILED: obj/third_party/ffmpeg/ffmpeg_yasm/autorename_libavcodec_x86_sbrdsp.o 
> python ../../third_party/yasm/run_yasm.py yasm -DPIC -felf64 -m amd64 -DARCH_X86_64 -w -P ../../third_party/ffmpeg/chromium/config/Chrome/linux/x64/config.asm -I../../third_party/ffmpeg/chromium/config/Chrome/linux/x64 -I../../third_party/ffmpeg/libavcodec/x86 -I../../third_party/ffmpeg/libavutil/x86 -I../../third_party/ffmpeg -I. -I../.. -Igen -DPIC -o obj/third_party/ffmpeg/ffmpeg_yasm/autorename_libavcodec_x86_sbrdsp.o ../../third_party/ffmpeg/libavcodec/x86/autorename_libavcodec_x86_sbrdsp.asm
> ../../third_party/ffmpeg/libavcodec/x86/autorename_libavcodec_x86_sbrdsp.asm:1: error: label or instruction expected at start of line

[Comment 1 Mike Gilbert 2016-09-15 01:10:02 UTC]

Looks like third_party/ffmpeg/chromium/scripts/generate_gn.py creates those autorename* files.

[Comment 2 Mike Gilbert 2016-09-15 03:46:45 UTC]

I added a patch to fix the asm output of generate_gn.py. Please submit it upstream if it looks reasonable.

https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/chromium/files/chromium-ffmpeg-generate_gn.patch

[Comment 3 Paweł Hajdan, Jr. (RETIRED) 2016-09-16 00:25:12 UTC]

Uploaded upstream https://chromium-review.googlesource.com/c/386336/ for review.