mp3cat is a utility that can read, write and clean-up mp3 files and streams.
Created attachment 36725 [details] eBuild for mp3cat 0.4
I'm fairly new to this eBuild writing business, so I do value any constructive criticism. I am sure the Gentoo devs will find a few things wrong with an eBuild as simple as this.
First, please attach files individually as plaintext rather than putting them all into an archive. Don't bother including the Manifest or digests; we generate those :) Forget the patch, because we usually don't want stuff in /usr/local. Use dobin instead. No need for "${PN}-${PV}". That's the same as "${P}". See: 1) http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1 2) http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3 3) /usr/portage/skel.ebuild
Thanks for taking the time to provide feedback; Can you explain a little about dobin - I have a makefile that wants to put everything into a spesific place when somebody does "make install" - are you saying that I should use dobin to 'manually' place the binaries in the os-approved area which I guess is /usr/bin?
Yes. Alternatively, you could use sed to fix the Makefile. This should do it: sed -i "s:/usr/local:\$\{DESTDIR\}/usr:" Makefile Whichever seems less ugly.
Created attachment 49389 [details] Reviewed ebuild. Use dobin instead of patch in order to install the package. Remove the inherit eutils, since no patch used. Use of sed in order to make the package compile with ${CFLAGS} Use of "${P}" instead of "${PN}-${PV}". Set the RESTRICT="nomirror", because file is not being mirrored anyware.
Created attachment 49438 [details] Reviewed ebuild. Sorry, I misunderstood nomirror keyword. New ebuild attached.
Looks OK to me. I'll get this in soon.
In portage.
