Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 59323 - Fixed pam_krb5-1.0-r1 for amd64
Summary: Fixed pam_krb5-1.0-r1 for amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-03 18:13 UTC by Greg Symons
Modified: 2004-08-19 15:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This patch modifies the pam_krb5 makefile to allow its own CFLAGS to be preserved (pam_krb5-1.0-preserve-cflags.diff,341 bytes, patch)
2004-08-03 18:18 UTC, Greg Symons
Details | Diff
Patches pam_krb5-1.0-r1.ebuild to set ~amd64 and set appropriate CFLAGS to build pam_krb5 (pam_krb5-1.0-r1.diff,876 bytes, patch)
2004-08-03 18:25 UTC, Greg Symons
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Symons 2004-08-03 18:13:52 UTC
I've successfully installed pam_krb5-1.0-r1 under amd64. It did require a little patching, however. I have patches both for the source and the ebuild itself. I will attach them shortly. I'd recommend moving pam_krb-1.0-r1 to ~amd64.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Greg Symons 2004-08-03 18:18:25 UTC
Created attachment 36722 [details, diff]
This patch modifies the pam_krb5 makefile to allow its own CFLAGS to be preserved

This first patch modifies the makefile for the package so that it's own CFLAGS
are preserved and portage CFLAGS are appended, so that they take precedence.
Comment 2 Greg Symons 2004-08-03 18:25:51 UTC
Created attachment 36724 [details, diff]
Patches pam_krb5-1.0-r1.ebuild to set ~amd64 and set appropriate CFLAGS to build pam_krb5

This second patch modifies the ebuild to apply the other patch and set the
GENTOOCFLAGS macro when make is called, so that pam_krb5's CFLAGS are
preserved.

We need to do this because pam_krb5 must be compiled with -fPIC on amd64. Since
I don't know if this is necessary on other platforms or not, I left the option
open to disable -fPIC through make.conf (though I can't really think of any
reasons for someone to want to do so).
Comment 3 Danny van Dyk (RETIRED) gentoo-dev 2004-08-08 10:09:02 UTC
Bad idea(tm) (no offense). IMHO this ebuild shouldn't do "make CFLAGS=${CFLAGS}" at all. It has a perfectly working makefile and pam_krb5 does not need any CFLAGS other than "-O2 -fPIC".

CC'ing the maintainer:

rphilips: Are you okay to change the "make ..." command to a plain emake ?
Comment 4 Ryan Phillips (RETIRED) gentoo-dev 2004-08-19 15:09:45 UTC
If the testing goes ok with emake, then go for it... There is no need for the extra patching.
Comment 5 Danny van Dyk (RETIRED) gentoo-dev 2004-08-19 15:20:11 UTC
In CVS now.