Created attachment 444840 [details, diff] Rename USE flag 'google' to 'google-drive' Dear maintainer The package app-office/libreoffice has a USE flag 'google', which enables Google Drive support in LibreOffice. In my personal opinion, the name of the USE flag is to generic and says nothing. Compare it with a USE flag called 'microsoft'. What does it enable? Windows support? Skype protocol? Something of the Azure Cloud? I therefore suggest to rename the USE flag 'google' to 'google-drive', thx. Here is a patch against libreoffice-5.1.4.2.ebuild which should also work against libreoffice-*-9999 ebuilds. The patch is also attached. diff -ru a/app-office/libreoffice/libreoffice-5.1.4.2.ebuild b/app-office/libreoffice/libreoffice-5.1.4.2.ebuild --- a/app-office/libreoffice/libreoffice-5.1.4.2.ebuild +++ b/app-office/libreoffice/libreoffice-5.1.4.2.ebuild @@ -78,7 +78,7 @@ # Extensions that need extra work: LO_EXTS="nlpsolver scripting-beanshell scripting-javascript wiki-publisher" -IUSE="bluetooth +branding coinmp collada +cups dbus debug eds firebird gltf gnome google +IUSE="bluetooth +branding coinmp collada +cups dbus debug eds firebird gltf gnome google-drive gstreamer +gtk gtk3 jemalloc kde libressl mysql odk postgres quickstarter telepathy test vlc $(printf 'libreoffice_extensions_%s ' ${LO_EXTS})" @@ -483,8 +483,8 @@ $(use_with coinmp system-coinmp) \ $(use_with collada system-opencollada) \ $(use_with gltf system-libgltf) \ - $(use_with google gdrive-client-id ${google_default_client_id}) \ - $(use_with google gdrive-client-secret ${google_default_client_secret}) \ + $(use_with google-drive gdrive-client-id ${google_default_client_id}) \ + $(use_with google-drive gdrive-client-secret ${google_default_client_secret}) \ $(use_with java) \ $(use_with mysql system-mysql-cppconn) \ $(use_with odk doxygen) \
That's why there is a USE flag description at your service: [+ C ] google app-office/libreoffice: Enable support for remote files on Google Drive Many other packages are using 'google' already, for slightly different use cases, but typically a person will either use Google services (having an account) or not (having no account). I am very much against introducing google-drive, google-search, google-contacts, ...
+1 for "google-drive".
> Andreas Sturmlechner wrote > > That's why there is a USE flag description at your service: > > [+ C ] google > app-office/libreoffice: Enable support for remote files on Google Drive > > Many other packages are using 'google' already, for slightly different use > cases, but typically a person will either use Google services (having an > account) or not (having no account). I am very much against introducing > google-drive, google-search, google-contacts, ... Note that Google offers many services, some of them which need an account (e.g. Gmail, Google Drive), some of them which don't need an account (e.g. Google search, Google Maps), and some of them which can be used with and without an account (e.g. Youtube). In my opinion, building support for accessing a storage device (using an account) is something totally different than building a search plug-in (not using an account) and therefore vindicates a separate USE flag. I also found two packages (see below) which already support a 'googledrive' USE flag. (I would therefore also change the request to name the USE flag 'googledrive' instead of 'google-drive' to be consistent.) Here is a (no exhaustive) list of packages using USE flags related to "google": app-leechcraft/lc-netstoremanager googledrive : Support Google Drive storage backend media-sound/clementine googledrive : Enable Google Drive support The descripton for dev-lang/io states dev-lang/io google : Build the google search add-on So here no account what so ever is needed. The following five packages use 'google' to access Google calendar and contacts. gnome-base/gvfs google : Enables support for accessing Google accounts via dev-libs/libgdata gnome-extra/evolution-data-server (unstable) google : Enable Google Contacts support. This will also enable the internal Google authentication support. [...] kde-apps/kdepim-common-libs google : Google service integration via net-libs/libkgapi kde-apps/kdepim-runtime google : Google service integration via net-libs/libkgapi (libkgapi = Library for accessing Google calendar and contact resources) mail-client/claws-mail gdata : Enable plugin for access to Google data providers (I don't use claws-mail but a quick search suggests that Google data providers means Google contact. ) Here are packages which use other Google services media-gfx/eog-pluginsc picasa : Enable uploading to Google's Picasa Web Albums app-leechcraft/lc-blasq vangog : Support Picasa service media-video/vlc chromecast : Enable experimental support for Google Chromecast net-misc/asterisk gtalk : Enable support for Google Talk services x11-libs/gtk+ cloudprint : Enable printing via Google Cloud Print media-plugins/grilo-plugins youtube : Build support for YouTube content discovery using dev-libs/libgdata media-sound/banshee youtube : Enable the Youtube plugin Following your argument 'youtube' (and all the others, too) should be renamed to 'google', because Youtube is a Google service using a Google account. So my point is, there are many, many Google products and services out there. The one-size-fits-all approach does not work any more. (Nor, in my honest opinion, should it have been used in the first place.) Therefore, different USE flags for separate products/functionality should be used.
Change the suggestion to name the USE flag 'googledrive' instead of 'google-drive' to be consistent with already existing USE flags of other packages (see post above).
CommitDate: Sat Sep 17 21:52:31 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1583c43b app-office/libreoffice: Rename useflag for Google Drive integration to googledrive in future versions
Thanks.
