Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592580 - net-misc/tlsdate fails to build with >=dev-libs/openssl-1.1.0
Summary: net-misc/tlsdate fails to build with >=dev-libs/openssl-1.1.0
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://github.com/ioerror/tlsdate/is...
Whiteboard: Pending removal: 2018-12-04
Keywords: NeedPatch, PMASKED
Depends on:
Blocks:
 
Reported: 2016-08-31 12:07 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2018-12-04 16:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,17.32 KB, text/plain)
2016-08-31 12:07 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-31 12:07:47 UTC
Created attachment 444616 [details]
build.log

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.     -march=native -mtune=native -O2 -pipe  -Wall -fno-strict-aliasing -c -o src/src_tlsdate_helper-tlsdate-helper.o `test -f 'src/tlsdate-helper.c' || echo './'`src/tlsdate-helper.c
src/tlsdate-helper.c: In function ‘openssl_time_callback’:
src/tlsdate-helper.c:377:11: error: dereferencing pointer to incomplete type ‘SSL {aka const struct ssl_st}’
       (ssl->state == SSL3_ST_CR_SRVR_HELLO_A || ssl->state == SSL3_ST_CR_SRVR_H
           ^
src/tlsdate-helper.c:377:22: error: ‘SSL3_ST_CR_SRVR_HELLO_A’ undeclared (first use in this function)
       (ssl->state == SSL3_ST_CR_SRVR_HELLO_A || ssl->state == SSL3_ST_CR_SRVR_H
                      ^
src/tlsdate-helper.c:377:22: note: each undeclared identifier is reported only once for each function it appears in
src/tlsdate-helper.c:377:63: error: ‘SSL3_ST_CR_SRVR_HELLO_B’ undeclared (first use in this function)
       (ssl->state == SSL3_ST_CR_SRVR_HELLO_A || ssl->state == SSL3_ST_CR_SRVR_H
                                                               ^
src/tlsdate-helper.c: In function ‘get_certificate_keybits’:
src/tlsdate-helper.c:414:21: error: dereferencing pointer to incomplete type ‘EVP_PKEY {aka struct evp_pkey_st}’
   switch (public_key->type)
                     ^
src/tlsdate-helper.c:418:18: warning: implicit declaration of function ‘BN_num_bits’ [-Wimplicit-function-declaration]
       key_bits = BN_num_bits(public_key->pkey.rsa->n);
                  ^
src/tlsdate-helper.c: In function ‘check_san’:
src/tlsdate-helper.c:698:18: error: dereferencing pointer to incomplete type ‘X509_EXTENSION {aka struct X509_extension_st}’
         tmp = ext->value->data;
                  ^
src/tlsdate-helper.c: In function ‘run_ssl’:
src/tlsdate-helper.c:1128:3: warning: implicit declaration of function ‘SSL_load_error_strings’ [-Wimplicit-function-declaration]
   SSL_load_error_strings();
   ^
src/tlsdate-helper.c:1129:3: warning: implicit declaration of function ‘SSL_library_init’ [-Wimplicit-function-declaration]
   SSL_library_init();
   ^
src/tlsdate-helper.c:1147:23: warning: implicit declaration of function ‘TLSv1_client_method’ [-Wimplicit-function-declaration]
     ctx = SSL_CTX_new(TLSv1_client_method());
                       ^
src/tlsdate-helper.c:1147:23: warning: passing argument 1 of ‘SSL_CTX_new’ makes pointer from integer without a cast [-Wint-conversion]
In file included from ./src/tlsdate-helper.h:38:0,
                 from src/tlsdate-helper.c:78:
/usr/include/openssl/ssl.h:1302:17: note: expected ‘const SSL_METHOD * {aka const struct ssl_method_st *}’ but argument is of type ‘int’
 __owur SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth);
                 ^
src/tlsdate-helper.c:1211:27: error: dereferencing pointer to incomplete type ‘SSL {aka struct ssl_st}’
   memcpy(&result_time, ssl->s3->server_random, sizeof (uint32_t));
                           ^
make[1]: *** [Makefile:1972: src/src_tlsdate_helper-tlsdate-helper.o] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-misc/tlsdate-0.0.13/work/tlsdate-0.0.13'
make: *** [Makefile:1366: all] Error 2
Comment 1 Hanno Böck gentoo-dev 2018-10-20 07:10:24 UTC
It may be time to last-rite tlsdate. No upstream activity for several years, the upstream version doesn't work anyway out of the box because it uses a server that doesn't send out TLS timestamps.

It would be desirable to have a secure time replacement packaged, e.g. Google's roughtime.
Comment 2 Craig Andrews gentoo-dev 2018-10-26 16:30:22 UTC
I cannot reproduce this issue.

USE="openssl" emerge =net-libs/libsrtp-2.2.0

Succeeds. I'm using dev-libs/openssl-1.1.1

I'm confident that this issue was solved by https://bugs.gentoo.org/592438#c5
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-10-26 16:57:56 UTC
(In reply to Craig Andrews from comment #2)
> I cannot reproduce this issue.
> 
> USE="openssl" emerge =net-libs/libsrtp-2.2.0
> 
> Succeeds. I'm using dev-libs/openssl-1.1.1
> 
> I'm confident that this issue was solved by https://bugs.gentoo.org/592438#c5

Wrong bug? This is about net-misc/tlsdate and not net-libs/libsrtp:0
Comment 4 Craig Andrews gentoo-dev 2018-10-26 18:23:32 UTC
Sorry about that :(
Comment 5 Craig Andrews gentoo-dev 2018-10-26 18:24:42 UTC
https://chromium-review.googlesource.com/c/chromiumos/third_party/tlsdate/+/549533/ has a fix for this issue
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-12-04 16:53:09 UTC
Removing wrt #637286.