Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 591444 - media-video/smplayer-16.8.0: version bump
Summary: media-video/smplayer-16.8.0: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: https://sourceforge.net/projects/smpl...
Whiteboard:
Keywords:
Depends on:
Blocks: 588584
  Show dependency tree
 
Reported: 2016-08-17 10:37 UTC by Coacher
Modified: 2016-08-17 16:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-08-17 10:37:52 UTC
Hello.

16.8.0 was released two weeks ago.

Please bump.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-17 11:07:31 UTC
x86_64-pc-linux-gnu-g++ -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--as-needed -o smplayer .obj/version.o .obj/global.o .obj/paths.o .obj/chapters.o .obj/helper.o .obj/colorutils.o .obj/translator.o .obj/subtracks.o .obj/tracks.o .obj/titletracks.o .obj/discname.o .obj/extensions.o .obj/desktopinfo.o .obj/myprocess.o .obj/mplayerversion.o .obj/playerid.o .obj/playerprocess.o .obj/infoprovider.o .obj/mplayerwindow.o .obj/mediadata.o .obj/mediasettings.o .obj/assstyles.o .obj/filters.o .obj/preferences.o .obj/filesettingsbase.o .obj/filesettings.o .obj/filesettingshash.o .obj/filehash.o .obj/images.o .obj/inforeader.o .obj/deviceinfo.o .obj/recents.o .obj/urlhistory.o .obj/core.o .obj/myscroller.o .obj/logwindow.o .obj/infowindow.o .obj/infofile.o .obj/seekwidget.o .obj/mytablewidget.o .obj/shortcutgetter.o .obj/actionseditor.o .obj/filechooser.o .obj/vdpauproperties.o .obj/preferencesdialog.o .obj/lineedit_with_icon.o .obj/mylineedit.o .obj/mycombobox.o .obj/tristatecombo.o .obj/languages.o .obj/selectcolorbutton.o .obj/prefwidget.o .obj/prefgeneral.o .obj/prefdrives.o .obj/prefinterface.o .obj/prefperformance.o .obj/prefinput.o .obj/prefsubtitles.o .obj/prefadvanced.o .obj/prefplaylist.o .obj/prefupdates.o .obj/prefnetwork.o .obj/filepropertiesdialog.o .obj/multilineinputdialog.o .obj/playlist.o .obj/playlistdock.o .obj/verticaltext.o .obj/eqslider.o .obj/videoequalizer.o .obj/audioequalizer.o .obj/myslider.o .obj/timeslider.o .obj/inputdvddirectory.o .obj/inputurl.o .obj/stereo3ddialog.o .obj/myaction.o .obj/myactiongroup.o .obj/filedialog.o .obj/inputmplayerversion.o .obj/about.o .obj/errordialog.o .obj/timedialog.o .obj/favorites.o .obj/favoriteeditor.o .obj/statewidget.o .obj/basegui.o .obj/baseguiplus.o .obj/autohidewidget.o .obj/widgetactions.o .obj/toolbareditor.o .obj/editabletoolbar.o .obj/clhelp.o .obj/cleanconfig.o .obj/smplayer.o .obj/myapplication.o .obj/main.o .obj/tvlist.o .obj/preftv.o .obj/tvsettings.o .obj/mpvprocess.o .obj/inforeadermpv.o .obj/mplayerprocess.o .obj/inforeadermplayer.o .obj/findsubtitlesconfigdialog.o .obj/findsubtitleswindow.o .obj/maiaObject.o .obj/maiaFault.o .obj/maiaXmlRpcClient.o .obj/osclient.o .obj/filedownloader.o .obj/subchooserdialog.o .obj/fixsubs.o .obj/defaultgui.o .obj/minigui.o .obj/mpcgui.o .obj/mpcstyles.o .obj/myicon.o .obj/mybutton.o .obj/panelseeker.o .obj/playcontrol.o .obj/mediapanel.o .obj/volumecontrolpanel.o .obj/mediabarpanel.o .obj/qpropertysetter.o .obj/actiontools.o .obj/skingui.o .obj/videopreview.o .obj/videopreviewconfigdialog.o .obj/inputbookmark.o .obj/bookmarkdialog.o .obj/globalshortcuts.o .obj/hdpisupport.o .obj/qrc_icons.o   -lz -lXext -lX11 -lm -lQt5Solutions_SingleApplication-2.6 -lQt5Solutions_LockedFile-2.4 -lQt5Widgets -lQt5Gui -lQt5Network -lQt5Xml -lQt5Core -lGL -lpthread 
.obj/playlist.o: In function `Playlist::openUrl(QString const&)':
playlist.cpp:(.text+0x3719): undefined reference to `LoadPage::fetchPage(QString const&)'
.obj/playlist.o: In function `Playlist::Playlist(QWidget*, QFlags<Qt::WindowType>)':
playlist.cpp:(.text+0x103b9): undefined reference to `LoadPage::LoadPage(QNetworkAccessManager*, QObject*)'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:675: smplayer] Error 1
make[1]: Leaving directory '/var/tmp/portage/media-video/smplayer-16.8.0/work/smplayer-16.8.0/src'
make: *** [Makefile:25: src/smplayer] Error 2
 * ERROR: media-video/smplayer-16.8.0::poly-c failed (compile phase):
 *   emake failed


Unless this bug is fixed the package cannot be committed. Feel free to provide fixes.
Comment 2 Coacher 2016-08-17 14:50:55 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Unless this bug is fixed the package cannot be committed. Feel free to
> provide fixes.
Here you go. You didn't attach build.log, but I guess you have 'streaming' USE disabled. The error you've posted references pieces of code, which are guarded by #ifdef PLAYLIST_DOWNLOAD. Several includes in the same file (src/playlist.cpp) are also guarded with #ifdef PLAYLIST_DOWNLOAD. One of this includes is "youtube/loadpage.h". Because smplayer[-streaming] seds out YOUTUBE_SUPPORT definition, the required pieces of code under src/youtube/ aren't compiled. Thus you get the error you see.

Fix: adjust your sed call to also take care of PLAYLIST_DOWNLOAD definition in src/playlist.h when 'streaming' USE is disabled, or move PLAYLIST_DOWNLOAD definition to src/smplayer.pro under YOUTUBE_SECTION.

See also https://app.assembla.com/spaces/smplayer/subversion/commits/8031
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-17 16:27:22 UTC
commit 1bb3cb09a32868dc95395151fe7eb77bed8963a7
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Aug 17 18:26:46 2016

    media-video/smplayer: Bump to version 16.8.0 (bug #591444).

    Package-Manager: portage-2.3.0
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>