Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 591060 - One of KPhotoAlbum's USE flags "map" and "geolocation" is redundant
Summary: One of KPhotoAlbum's USE flags "map" and "geolocation" is redundant
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-11 18:12 UTC by Tobias Leupold
Modified: 2016-08-11 20:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-Remove-stray-marble-references.patch (0001-Remove-stray-marble-references.patch,3.38 KB, patch)
2016-08-11 19:11 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2016-08-11 18:12:40 UTC
Hi :-)

(Just fyi: I'm one of KPA's developers, and) I was just fiddling around with my system-wide KPA installation (remove USE flags to avoid KF5 blocks), when I saw that KPA has a "geolocation" and a "map" USE flag.

The "geolocation" one pulls Marble:
    geolocation? ( $(add_kdeapps_dep marble) )

and the "map" one pulls libkgeomap:
    map? ( >=kde-apps/libkgeomap-15.08.3:4 )

I think that one of these is redundant. (Please correct me if I'm wrong!) It's about compiling the map view or not. For this, we need libkgeomap, which itself pulls Marble. I don't think we use Marble anywhere else ... so what's the point of the "geolocation" USE flag?

So I would propose to keep the "map" USE flag, which does the job, and delete the "geolocation" USE flag. This is also a bit misleading, as the "real" geolocation stuff (geotagging etc.) is provided through our KIPI interface.

As said: please correct me if I'm wrong :-)

Cheers, Tobias
Comment 1 Michael Palimaka (kensington) gentoo-dev 2016-08-11 18:36:39 UTC
It looks like this was carried over from the 4.5 ebuild since apparently marble used to be used directly (prior to 2b8273cc3fbed13c625cb7638fe14f824650ee12).

I guess we didn't notice since there's still a few stray marble-related things in the build system (want a patch?).
Comment 2 Tobias Leupold 2016-08-11 19:03:19 UTC
Do we actually have marble-related stuff other than the MapView class?! Patches are always welcome ;-)
Comment 3 Michael Palimaka (kensington) gentoo-dev 2016-08-11 19:11:42 UTC
Created attachment 443078 [details, diff]
0001-Remove-stray-marble-references.patch
Comment 4 Tobias Leupold 2016-08-11 19:15:36 UTC
Thanks a lot, I'll ask the KPA big boys about that, but I'm pretty sure we can safely remove the marble stuff. I'll inform you when we're done :-)
Comment 5 Michael Palimaka (kensington) gentoo-dev 2016-08-11 20:33:07 UTC
Thanks! Fixed in git.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=434440044a2c8907fd86c7d5fc9c4b64134f7221