Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590984 - Maintainership request: sys-block/targetcli-fb
Summary: Maintainership request: sys-block/targetcli-fb
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on: 590722 598312 598472
Blocks:
  Show dependency tree
 
Reported: 2016-08-10 22:13 UTC by Diogo Pereira
Modified: 2017-07-19 16:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Very simple targetcli-fb init script (target-fb,762 bytes, text/plain)
2016-09-02 08:48 UTC, toon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo Pereira 2016-08-10 22:13:30 UTC
I submitted a pull request to add this package to the tree: https://github.com/gentoo/gentoo/pull/2043

See also bug 590722.
Comment 1 toon 2016-09-02 08:44:30 UTC
Yes, I welcome this initiative very much!
The original targetcli package has been unmaintained for years and suffers bit rot.
The fork (targetcli-fb is maintained.
Also, it is much cleaner than the original code.
In order to install targetcli-fb I was forced to create a local repository.
Also, I was forced to write an very simple init script for it.
Please note that targetcli-fb depends on configshell-fb and rtslib-fb.
My local repo looks like this:

workstation ~ # cd /usr/local/portage/
workstation portage # tree
.
├── dev-python
│   ├── configshell-fb
│   │   ├── configshell-fb-1.1.18.ebuild
│   │   ├── configshell-fb-1.1.20.ebuild
│   │   └── Manifest
│   └── rtslib-fb
│       ├── Manifest
│       ├── rtslib-fb-2.1.57.ebuild
│       └── rtslib-fb-2.1.60.ebuild
├── metadata
│   └── layout.conf
├── profiles
│   └── repo_name
└── sys-block
    └── targetcli-fb
        ├── Manifest
        ├── targetcli-fb-2.1.41.ebuild
        └── targetcli-fb-2.1.43.ebuild
Comment 2 toon 2016-09-02 08:48:18 UTC
Created attachment 444774 [details]
Very simple targetcli-fb init script

This is a very simple init script I wrote for targetcli-fb.
Install it in /etc/init.d
The contents of /etc/conf.d/targetcli-fb are:

rc_need="net.ovsbr1"
TARGETCTL="/usr/bin/targetctl"
TARGET_CONFIG="/etc/target/saveconfig.json"
Comment 3 alexander haensch 2016-09-16 09:10:44 UTC
+1 for this effort.
Would it be possible to add a systemd.unit to the package?

A very simple unit like the following works for me:


[Unit]
Description=Restore LIO kernel target configuration
Requires=sys-kernel-config.mount
After=sys-kernel-config.mount network.target local-fs.target

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/bin/targetctl restore
ExecStop=/usr/bin/targetctl clear
SyslogIdentifier=target

[Install]
WantedBy=multi-user.target
Comment 4 Diogo Pereira 2016-09-16 11:13:57 UTC
(In reply to alexander haensch from comment #3)
> Would it be possible to add a systemd.unit to the package?

targetctl belongs to dev-python/rtslib-fb, so that's probably where the systemd unit should go.
Comment 5 Diogo Pereira 2016-09-16 11:16:04 UTC
(Same for the init script)
Comment 6 Patrice Clement gentoo-dev 2017-07-19 16:26:43 UTC
PR merged a while ago. Thanks!