Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590490 - sci-libs/libqalculate-0.9.9[-readline]: build failure: qalc.cc:3182:11: error: 'historyfile' was not declared in this scope
Summary: sci-libs/libqalculate-0.9.9[-readline]: build failure: qalc.cc:3182:11: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Related Packages
URL: https://github.com/Qalculate/libqalcu...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 596672
  Show dependency tree
 
Reported: 2016-08-04 17:10 UTC by Ryoto Yayame
Modified: 2016-11-27 12:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch for libqalculate-0.9.9 (libqalculate-0.9.9-historyfile-was-not-declared-in-this-scope.patch,424 bytes, patch)
2016-08-04 17:10 UTC, Ryoto Yayame 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryoto Yayame 2016-08-04 17:10:47 UTC 
Created attachment 442528 [details, diff]
Patch for libqalculate-0.9.9

Emerging libqalculate-0.9.9 with USE="-readline" fails with:

> qalc.cc: In function 'void load_preferences()':
> qalc.cc:3182:11: error: 'historyfile' was not declared in this scope
>     g_free(historyfile);

Variable 'historyfile' is indeed only declared in this function, if HAVE_LIBREADLINE has been defined. This line was missed when #ifdef'ing the other uses of this variable.

Patch attached. Emerges fine with it.

I reported it upstream here:
https://github.com/Qalculate/libqalculate/issues/6
Comment 1 Pacho Ramos gentoo-dev 2016-11-27 12:43:09 UTC 
[master eef49a7] sci-libs/libqalculate: Fix compilation with -readline USE (#590490 by Ryoto Yayame)
 2 files changed, 18 insertions(+)
 create mode 100644 sci-libs/libqalculate/files/libqalculate-0.9.9-readline.patch