Bug 590228 – sys-fs/multipath-tools-0.6.2 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Xose Vazquez Perez 2016-08-01 17:44:26 UTC]

Latest upstream release: 0.6.2
Current version/release in gentoo: 0.5.0-r1
URL: http://christophe.varoqui.free.fr/

Thank you.

[Comment 1 Robin Johnson 2016-08-05 18:43:57 UTC]

Fixed in tree:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e78d65c9e9ffa54a6bece600c8d09881361c4889

[Comment 2 Xose Vazquez Perez 2016-08-06 21:21:50 UTC]

Hi,

There is a bug at multipath-tools-0.6.2-makefile.patch:

diff -Nuar --exclude '*~' multipath-tools-e165b73.orig/mpathpersist/Makefile multipath-tools-e165b73/mpathpersist/Makefile
--- multipath-tools-e165b73.orig/mpathpersist/Makefile  2016-07-22 02:38:14.000000000 -0700
+++ multipath-tools-e165b73/mpathpersist/Makefile       2016-08-05 10:47:28.248804380 -0700
@@ -5,26 +5,24 @@
 OBJS = main.o

 CFLAGS += -I$(multipathdir) -I$(mpathpersistdir)
-LDFLAGS += -lpthread -ldevmapper -L$(mpathpersistdir) -lmpathpersist -L$(multipathdir) -L$(mpathcmddir) -lmpathcmd -lmultipath -ludev
+LIBS += -lpthread -ldevmapper -L$(mpathpersistdir) -lmpathpersist -L$(multipathdir) -L$(mpathcmddir) -lmpathcmd -lmultipath -ludev

 EXEC = mpathpersist

 all: $(EXEC)

 $(EXEC): $(OBJS)
-       $(CC) -g $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)
-       $(GZIP) $(EXEC).8 > $(EXEC).8.gz
+       $(CC) $(CFLAGS) $(CFLAGS) -g $(OBJS) -o $(EXEC) $(LIBS)
              ^^^^^^^^^^^^^^^^^^


"$(CFLAGS)" is duplicate, one of them should be replaced by $(LDFLAGS)


And a request, could you please split this patch and send relevant parts to upstream? Obviously without the change of man pages.
Or it  will be a ping-pong.


Thank you.

[Comment 3 Robin Johnson 2016-08-08 20:27:45 UTC]

(In reply to Xose Vazquez Perez from comment #2)
> There is a bug at multipath-tools-0.6.2-makefile.patch:
...
> "$(CFLAGS)" is duplicate, one of them should be replaced by $(LDFLAGS)
Fixed in -r1.

> And a request, could you please split this patch and send relevant parts to
> upstream? Obviously without the change of man pages.
> Or it  will be a ping-pong.
Upstream rejected the changes years ago; if you think they'll treat it differently, feel free to try again.

[Comment 4 Xose Vazquez Perez 2016-11-03 23:38:00 UTC]

(In reply to Robin Johnson from comment #3)

> (In reply to Xose Vazquez Perez from comment #2)
>
> > And a request, could you please split this patch and send relevant parts to
> > upstream? Obviously without the change of man pages.
> > Or it  will be a ping-pong.
>
> Upstream rejected the changes years ago; if you think they'll treat it
> differently, feel free to try again.

FYI, 0.6.4 was released today with those (multipath-tools-0.6.2-makefile.patch) changes applied.