Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590220 - [vmware overlay] app-emulation/vmware-modules-308.1.1 with kernel-4.7 fails to modprobe vmblock
Summary: [vmware overlay] app-emulation/vmware-modules-308.1.1 with kernel-4.7 fails t...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2016-08-01 16:54 UTC by Harris Landgarten
Modified: 2017-11-30 10:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
308-4.07-01-readlink_copy.patch (308-4.07-01-readlink_copy.patch,522 bytes, patch)
2016-08-04 08:06 UTC, Fabio Rossi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harris Landgarten 2016-08-01 16:54:25 UTC
sudo modprobe vmblock
modprobe: ERROR: could not insert 'vmblock': Unknown symbol in module, or unknown parameter (see dmesg)

from journalctl:

kernel: vmblock: Unknown symbol readlink_copy (err 0)
Comment 1 Fabio Rossi 2016-08-03 20:21:34 UTC
I have noticed today the same problem after merging kernel 4.7 and recompiling vmware-modules. readlink_copy() is not anymore exported after commit:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=bfe8804d908a791b16e3686c101f0d7eca9fb5b9

I don't have experience in that sense, maybe it'd make sense to replace it with generic_readlink() ?
Comment 2 Harris Landgarten 2016-08-04 01:55:29 UTC
As a quick workaround I replaced:

return readlink_copy(buffer, buflen,  link)

with return generic_readlink(dentry, buffer, buflen) in vmblock_only/linux/inode.c

It compiles and now modprobe and I believe it should work.

It is duplicating function though.

I think we can replace the vfs_readlink and the readlink_copy with a single call to generic_readlink.

Take a look and see what you think.
Comment 3 Harris Landgarten 2016-08-04 02:50:49 UTC
I can verify the cut/paste from and to by window 7 vm is working.
Comment 4 Fabio Rossi 2016-08-04 08:05:24 UTC
(In reply to Harris Landgarten from comment #3)
> I can verify the cut/paste from and to by window 7 vm is working.

vmblock should be used to implement the software layer for hard disk emulation, shouldn't be? Anyway generic_readlink() is doing more things than readlink_copy() but I'm not an expert in that area. Before pushing a patch into the overlay I'd like to be sure it's not causing problems. I'm attaching here a proposed patch.
Comment 5 Fabio Rossi 2016-08-04 08:06:19 UTC
Created attachment 442450 [details, diff]
308-4.07-01-readlink_copy.patch

proposal
Comment 6 Harris Landgarten 2016-08-04 11:36:25 UTC
From Vmware Docs:

vmblock Module Used in Workstation and Fusion, this module is essential for drag-and-drop
copy operations between hosts and guests.

I don't think it has anything to do with hard disk emulation.

I have tested copy/paste and drag/drop between machines and it is now working.
Comment 7 Fabio Rossi 2016-08-04 13:18:17 UTC
(In reply to Harris Landgarten from comment #6)
> From Vmware Docs:
> 
> vmblock Module Used in Workstation and Fusion, this module is essential for
> drag-and-drop
> copy operations between hosts and guests.
> 
> I don't think it has anything to do with hard disk emulation.
> 
> I have tested copy/paste and drag/drop between machines and it is now
> working.

Ok, good! I'll push later the patch to the overlay
Comment 8 Manfred Knick 2017-07-07 21:08:53 UTC
REFERENCE:

Bug 616958 :  12.5.7 version bump

Current [Overlay] already includes:

           app-emulation/vmware-modules-308.5.7:0

(Harris Landgarten from comment #6)
> I have tested copy/paste and drag/drop between machines and it is now
> working.

Harris is on "~amd64";
I have tested "amd64" with 12.5.7: CONFIRMATION, WORKSFORME.

Current [ebuild] /files contains 308-4.07-01-readlink_copy.patch -
"Thanks" to Fabio!

To me, this bug seems to be FIXED / OBSOLETE.
Comment 9 Manfred Knick 2017-11-30 10:58:56 UTC
VMware Products have been removed from Main Portage Tree during Nov-2017.

Further development has been relegated to [vmware] Overlay.

Situation as of today, 30-Nov-2017:
Workstation : stable in [vmware] = 12.5.8  / released = 14.0.0  : Bug 634770
Player      : stable in [vmware] = 12.5.8  / released = 14.0.0  : Bug 639162
Modules     : stable in [vmware] = 308.5.8 / released = 329.0.0 : Bug 634862
Tools       : stable in [vmware] = 10.1.6  / released = 10.1.15 : Bug 634854