Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589894 - sys-devel/make: CXX defaults to g++ instead of c++
Summary: sys-devel/make: CXX defaults to g++ instead of c++
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-28 02:27 UTC by zhanglei.april
Modified: 2017-04-14 16:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zhanglei.april 2016-07-28 02:27:28 UTC 
GNU Make defaults CXX to g++ instead of c++, which is problematic on systems where g++ isn't the default C++ compiler or gcc/g++ are not provided at all (e.g. modern FreeBSD). In either case, c++ is still valid; it could be a symlink to or a copy of whatever C++ compiler used as the default.

FWIW, macOS's modified version of GNU Make and FreeBSD's own Make both default CXX to c++.
Comment 1 SpanKY gentoo-dev 2016-08-01 03:24:24 UTC 
feel free to make such a request upstream:
  https://savannah.gnu.org/bugs/?func=additem&group=make

i don't see us changing make.
Comment 2 zhanglei.april 2016-08-11 08:56:32 UTC 
(In reply to SpanKY from comment #1)
> feel free to make such a request upstream:
>   https://savannah.gnu.org/bugs/?func=additem&group=make
> 
> i don't see us changing make.

I'm proposing to apply a downstream patch to Make so that CXX defaults to c++ instead of g++.

This makes sense if we want to support non-gcc compilers as default compiler in Gentoo. Please see this thread for discussion: https://archives.gentoo.org/gentoo-dev/message/4419c24d5d4e55422f725580c729bd4f
Comment 3 SpanKY gentoo-dev 2016-08-11 14:23:30 UTC 
(In reply to Lei Zhang from comment #2)

your request is not Gentoo specific and should go upstream
Comment 4 zhanglei.april 2016-08-11 15:10:03 UTC 
(In reply to SpanKY from comment #3)
> (In reply to Lei Zhang from comment #2)
> 
> your request is not Gentoo specific and should go upstream

I tried, but the upstream guys seem not interested...
Comment 5 SpanKY gentoo-dev 2016-08-11 16:13:15 UTC 
you haven't linked to any upstream discussions
Comment 6 zhanglei.april 2016-08-11 23:52:08 UTC 
(In reply to SpanKY from comment #5)
> you haven't linked to any upstream discussions

Sorry. Here it is:
http://lists.gnu.org/archive/html/bug-make/2016-07/msg00020.html
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-07 07:22:48 UTC 
Guys, any reason not to proceed here?
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-12 16:54:42 UTC 
Reopening to hopefully get some attention here and a final decision how to proceed.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-14 16:32:34 UTC 
commit 41815b5598cad067c07e1c6f09b118e2114a675f
Author:     Lei Zhang <zhanglei.april@gmail.com>
AuthorDate: Wed Jul 27 23:36:35 2016
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Fri Apr 14 18:27:59 2017

    sys-devel/make: default CXX to c++ instead of g++, #589894
    
    Now with ~arch revbump!
    
    Closes: https://github.com/gentoo/gentoo/pull/1982
    Package-Manager: portage-2.2.28
    Reviewed-by: Anthony G. Basile <blueness@gentoo.org>