589708 – sys-auth/sssd-1.13.1 move epatch_user

Bug 589708 - sys-auth/sssd-1.13.1 move epatch_user

Summary: sys-auth/sssd-1.13.1 move epatch_user

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	AMD64 Linux

Importance:	Normal normal
Assignee:	Mikle Kolyada (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-07-25 21:11 UTC by Daniel Kuehn (RETIRED)
Modified:	2018-11-10 21:40 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Move epatch_user to before multilib_copy_sources (file_589708.txt,360 bytes, text/plain) 2016-07-25 21:13 UTC, Daniel Kuehn (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Kuehn (RETIRED) gentoo-dev

2016-07-25 21:11:18 UTC

Having epatch_user after multilib_copy_sources results in whatever patches the user wanted to apply, gets applied, but in the source tree that the compilation is not going to be in.



Reproducible: Always

Steps to Reproduce:
1. add a patch in /etc/portage/patches/sys-auth/sssd
2. emerge sssd
3.
Actual Results:  
Whatever user-supplied patch is applied in a source directory that isn't compiled in, thus the effect of the users patch is void to the compiled binary.

Expected Results:  
The user-supplied patch is applied in the directory that is compiled and thus be able to affect the compiled binary.

Just moving epatch_user to before multilib_copy_sources fixes the problem.

Comment 1 Daniel Kuehn (RETIRED) gentoo-dev

2016-07-25 21:13:34 UTC

Created attachment 441552 [details]
Move epatch_user to before multilib_copy_sources

Comment 2 Mikle Kolyada (RETIRED) archtester

2018-11-10 21:40:46 UTC

with no-op src_prepare the bug does not make sense anymore