589540 – x11-misc/slim: use of REPLACING_VERSIONS does not account for multiple values

Bug 589540 - x11-misc/slim: use of REPLACING_VERSIONS does not account for multiple values

Summary: x11-misc/slim: use of REPLACING_VERSIONS does not account for multiple values

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Ian Stakenvicius (RETIRED)

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	589444
	Show dependency tree

Reported:	2016-07-23 13:10 UTC by Michał Górny
Modified:	2016-07-25 14:37 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-23 13:10:21 UTC

See the tracker bug.

  # note, $REPLACING_VERSIONS will always contain 0 or 1 PV's for slim

note: you have no reason to make assumptions like this.

  if ! version_is_at_least "1.3.2-r7" "${REPLACING_VERSIONS:-1.0}" ; then

This is going to fail hard when RV has >1 value.

Comment 1 Ian Stakenvicius (RETIRED) gentoo-dev

2016-07-25 14:37:14 UTC

commit 0413ea769ca646facbcf7b8c797778a0fff98aa9
Author: Ian Stakenvicius <axs@gentoo.org>
Date:   Mon Jul 25 10:36:41 2016 -0400

    x11-misc/slim: process ${REPLACING_VERSIONS} as a list
    
    Bug: http://bugs.gentoo.org/589540