Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589386 - sys-apps/portage-2.2.28 - repoman does not commit license files but does not even warn about them being skipped
Summary: sys-apps/portage-2.2.28 - repoman does not commit license files but does not ...
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-22 18:49 UTC by Martin Mokrejš
Modified: 2022-07-12 03:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Mokrejš 2016-07-22 18:49:05 UTC
It happened to me several times that I did:

cd sci-biology/foo
git add ../../license/foo
git add *
repoman commit * ../../license/foo

while expecting repoman (like git) will put into the commit all the files. Now, after months and occasional complaints from other devs that I did not add a license file ... I finaly realized what is going on.

Justin Lecher says this is not a bug in repoman and it only works inside a package directory. Maybe, but then I propose to at least print on STDERR that one of the file scheduled (sorry, no, I mean one of the files included on the commandline in ARGS) for a commit was ignored.

Or maybe extend the functionality? ;-)
Comment 1 William L. Thomson Jr. 2016-11-15 20:16:15 UTC
Not sure about this, repoman is only for packages. There are other things in tree that are not packages. For licenses, eclasses, profiles, and other things you do not use repoman to commit, just use git commit.

I would recommend to close as invalid, as it is not proper use of repoman. It might seem repoman is for an entire repository. But all repoman cares about is package depgraph, and other ebuild related QA issues.
Comment 2 William L. Thomson Jr. 2016-11-15 20:18:45 UTC
Seems repoman may be used for some things like eclasses (bug# 64258) that would benefit from a digest/signature to ensure it is not modified. I do not think such would apply to License files.
Comment 3 Zac Medico gentoo-dev 2016-11-16 00:32:25 UTC
For MetaManifest (bug 349026), the goal is to be able to verify the integrity of the *entire* tree, which obviously includes the licenses.

Bug 390651 is related, in the sense that it would be bad to commit a ebuild which inherits an eclass that has uncommitted changes. Also, it would be bad to commit an ebuild which has a dependency on another ebuild which has not been committed.
Comment 4 Zac Medico gentoo-dev 2016-11-16 17:46:59 UTC
Also, it's bad to commit an ebuild when the profiles and/or metadata directories have uncommitted changes.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:33 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.