Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589324 - kde-plasma/kde-cli-tools[-kdesu]: kwidgetsaddons is not required
Summary: kde-plasma/kde-cli-tools[-kdesu]: kwidgetsaddons is not required
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-21 09:51 UTC by Coacher
Modified: 2016-07-21 10:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-07-21 09:51:10 UTC 
Hello.

It looks like the only program from kde-cli-tools that relies on kwidgetsaddons is kdesu: https://github.com/KDE/kde-cli-tools/search?utf8=%E2%9C%93&q=WidgetsAddons&type=Code

Please move kwidgetsaddons dependency under kdesu USE.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2016-07-21 10:00:41 UTC 
It's also appears to be used by kcmshell for KPageDialog.
Comment 2 Coacher 2016-07-21 10:02:54 UTC 
Hmm.

Actually it appears that kwidgetsaddons are actually used elsewhere: https://github.com/KDE/kde-cli-tools/blob/master/keditfiletype/kservicelistwidget.cpp#L33

Maybe someone should tell upstream that their CMake files have insufficient deps.
Comment 3 Coacher 2016-07-21 10:03:23 UTC 
(In reply to Michael Palimaka (kensington) from comment #1)
> It's also appears to be used by kcmshell for KPageDialog.
Yeah. Cmakelists are incomplete.