589256 – net-misc/tinc-1.1_pre14: ebuild uses wrong configure argument to add miniupnpc support

Bug 589256 - net-misc/tinc-1.1_pre14: ebuild uses wrong configure argument to add miniupnpc support

Summary: net-misc/tinc-1.1_pre14: ebuild uses wrong configure argument to add miniupnp...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Anthony Basile

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-07-20 17:12 UTC by Jeremi Piotrowski
Modified:	2016-07-21 01:32 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
emerge --info (file_589256.txt,6.19 KB, text/plain) 2016-07-20 17:12 UTC, Jeremi Piotrowski	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeremi Piotrowski 2016-07-20 17:12:53 UTC

Created attachment 441234 [details]
emerge --info

When I emerge tinc-1.1 with USE=upnp, currently it does not activate the upnp functionality in the package.

The ebuild uses the configure argument

    $(use_with upnp miniupnpc)

but the configure script expects:

    --enable-miniupnpc

see configure.ac:247 :

    tinc_MINIUPNPC
    AM_CONDITIONAL(MINIUPNPC, test "x$enable_miniupnpc" = "xyes")

after changing the ebuild to use

    $(use_enable upnp miniupnpc)

the functionality is correctly compiled in.

Comment 1 Yixun Lan archtester

2016-07-21 01:32:32 UTC

thanks for reporting, I've pushed this fix without revision bump

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b2a76fd22d1521b5fe4c079b87f2a0c82da874e