Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588970 - cmake-utils.eclass - cmake-utils_use_(enable|with): consider switching from ON/OFF to 1/0
Summary: cmake-utils.eclass - cmake-utils_use_(enable|with): consider switching from O...
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal trivial
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 07:21 UTC by Jeroen Roovers (RETIRED)
Modified: 2016-08-24 19:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2016-07-17 07:21:35 UTC 
cmake can match strings but C/C++ preprocessor directives cannot trivially do the same.

cmake accepts with/enable with ON/OFF, TRUE/FALSE (and so on) as well as 1/0, so if we switch to the latter, we can simplify patches that re-use the cmake directives as preprocessor directives.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2016-07-17 17:39:39 UTC 
Could you please show a sample of where this will help?