Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 58891 - New mldonkey version 2.5.27
Summary: New mldonkey version 2.5.27
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Jon Hood (RETIRED)
URL:
Whiteboard:
Keywords:
: 59309 60187 (view as bug list)
Depends on: 60390
Blocks:
  Show dependency tree
 
Reported: 2004-07-30 07:19 UTC by Ben
Modified: 2004-08-16 13:22 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mldonkey-2.5.22 ebuild (mldonkey-2.5.22.ebuild,2.73 KB, text/plain)
2004-07-30 07:20 UTC, Ben
Details
mldonkey-2.5.22 ebuild (mldonkey-2.5.22.ebuild,2.72 KB, text/plain)
2004-07-30 07:25 UTC, Ben
Details
mldonkey-2.5.22 ebuild (mldonkey-2.5.22.ebuild,2.79 KB, text/plain)
2004-07-30 11:27 UTC, Ben
Details
Patchpack 22a (patch_pack22a_gentoo.gz,7.73 KB, application/octet-stream)
2004-07-30 18:26 UTC, spiralvoice
Details
mldonkey-2.5.22 including patch (mldonkey-2.5.22.ebuild,2.87 KB, text/plain)
2004-07-31 01:16 UTC, Ben
Details
mldonkey-2.5.22.ebuild (mldonkey-2.5.22.ebuild,3.03 KB, text/plain)
2004-08-01 04:55 UTC, Ben
Details
mldonkey-2.5.22.ebuild including pachtset (mldonkey-2.5.22.ebuild,2.98 KB, text/plain)
2004-08-02 12:14 UTC, Ben
Details
mldonkey-2.5.22.ebuild (mldonkey-2.5.22-r1.ebuild,2.74 KB, text/plain)
2004-08-02 12:46 UTC, Jon Hood (RETIRED)
Details
net-p2p/mldonkey-2.5.22-r1.ebuild (mldonkey-2.5.22-r1.ebuild,2.73 KB, text/plain)
2004-08-03 20:46 UTC, Jon Hood (RETIRED)
Details
Experimental CVS ebuild for 2.5.27 w/ spiralvoice patchpack 27b (mldonkey-2.5.27b_p.ebuild,2.78 KB, text/plain)
2004-08-13 16:27 UTC, Curtis Magyar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2004-07-30 07:19:17 UTC
New mldonkey version.
Comment 1 Ben 2004-07-30 07:20:56 UTC
Created attachment 36466 [details]
mldonkey-2.5.22 ebuild

Made some changes to the ebuild.
1. Removed the patch as it doesnt work with this version anymore
2. GTK gui build is now build with --enable-gtk2. Changed the script to do that
when gtk gui is wanted.
Comment 2 Ben 2004-07-30 07:22:24 UTC
Its not clear if the download bug is fixed. If someone knows please say so.
Comment 3 Ben 2004-07-30 07:25:39 UTC
Created attachment 36467 [details]
mldonkey-2.5.22 ebuild

Removed some debug infos that were just for testing the new release
Comment 4 Ben 2004-07-30 11:27:32 UTC
Created attachment 36478 [details]
mldonkey-2.5.22 ebuild

If gtk2 is not in use flag we dont want the gui to be compiled. Configure
wanted so gtk lib even if the gui should not be compiled. Problem should be
fixed
Comment 5 Ben 2004-07-30 11:28:53 UTC
Download bug is still not fixed.
Comment 6 spiralvoice 2004-07-30 18:26:44 UTC
Created attachment 36493 [details]
Patchpack 22a

Because my webspace provider has some login problems I will post the first
patchpack for CVS 2-5-22 here. Included are these patches:
2974 3053 3064 3146 3157 3160 3183 3235 3242 3245 3246 3249 3250 3251
Descriptions can be found on Savannah:
http://savannah.nongnu.org/patch/?group=mldonkey
Comment 7 spiralvoice 2004-07-30 18:28:18 UTC
What download bug do you mean?
Comment 8 Ben 2004-07-31 01:16:51 UTC
Created attachment 36504 [details]
mldonkey-2.5.22 including patch

New ebuild file to use the patchset provided. Also the gtk issue should
besolved. Added new dependencie gtk2. If someone wants the new gui to be
compiled against gtk2.
Comment 9 Ben 2004-07-31 01:18:05 UTC
Theres is a download bug, that makes you set your max_download_rate two times the actual rate you want. 
Comment 10 spiralvoice 2004-07-31 13:33:11 UTC
According to /usr/portage/profiles/use.local.desc there is a USE flag for MLDonkey:
net-p2p/mldonkey:mldonkeypango - enable pango patches for mldonkey
Should this flag be used in MLDonkey ebuilds?
Comment 11 Ben 2004-08-01 04:55:08 UTC
Created attachment 36575 [details]
mldonkey-2.5.22.ebuild

New ebuild now uses the mldonkeypango flag. As some people might not know this
new flag I added an info informing people about it.
Comment 12 Jon Hood (RETIRED) gentoo-dev 2004-08-02 11:43:08 UTC
a few questions:
1) why is http://www.8ung.at/spiralvoice/patches/patch_pack21g in the SRC_URI
2) what is the point of mldonkeypango USE flag- can it be removed? your patch_pack-22a doesn't look all pango-centric at all
3) I'm not sure I understand some of the logic in what all this patch does, and some lines (though I admit I haven't looked at the code as much as I should have), became a bit confusing in the code- I can't tell what all is being updated- could you give me a quick overview?
Comment 13 Ben 2004-08-02 12:04:07 UTC
I removed the src to the patch I simply overlocked it.

For the description of the patches go to http://savannah.nongnu.org/patch/?group=mldonkey and look for the patches 
2974 3053 3064 3146 3157 3160 3183 3235 3242 3245 3246 3249 3250 3251

As it doesnt look like there are no more pango patches I used the USE variable to patch the core with the supplied patchpack
Comment 14 Ben 2004-08-02 12:14:57 UTC
Created attachment 36657 [details]
mldonkey-2.5.22.ebuild including pachtset

Removed the link to the old patches from src_uri
Comment 15 Jon Hood (RETIRED) gentoo-dev 2004-08-02 12:46:07 UTC
Created attachment 36658 [details]
mldonkey-2.5.22.ebuild

hmm, gtk2 gui fails to compile, though everything else seems to work ok

ocamlopt.opt -inline 10    -I src/utils/cdk  -I src/daemon/chat  -I
src/gtk2/chat  -I src/utils/lib  -I src/utils/ocamlrss	-I src/utils/xml-light 
-I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver	-I
src/utils/mp3tagui  -I src/config/unix	-I src/gtk2/newgui  -I
src/gtk2/configwin  -I src/gtk2/okey  -I src/gtk2/gpattern  -I icons/tux  -I
+lablgtk2  -I src/gtk2/progress  -I src/gtk2/im  -I src/gtk2/im/yahoo  -I
src/gtk2/im/irc  -I src/networks/gnutella  -I src/networks/gnutella2  -I
src/networks/fasttrack	-I src/networks/fileTP	-I src/networks/bittorrent  -I
src/networks/donkey -c src/gtk2/newgui/gui_results_base.ml
File "src/gtk2/newgui/gui_results_base.ml", line 61, characters 4-16:
Unbound value GBroken.tree
make: *** [src/gtk2/newgui/gui_results_base.cmx] Error 2
Comment 16 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-03 07:20:24 UTC
Jon Hood - try:
emerge -C lablgtk-2.2.0 (i think)
emerge -v =lablgtk-1.2.6
and then try to emerge mldonkey.

PS. Both versions of lablgtk may be installed on the system at once, but it's not working with mldonkey.... I do not know why....

Regards,
Przemek
Comment 17 Jon Hood (RETIRED) gentoo-dev 2004-08-03 18:39:52 UTC
*** Bug 59309 has been marked as a duplicate of this bug. ***
Comment 18 Jon Hood (RETIRED) gentoo-dev 2004-08-03 20:46:49 UTC
Created attachment 36729 [details]
net-p2p/mldonkey-2.5.22-r1.ebuild

ok, the gtk2 frontend will not build on my gcc-3.4 ~x86 box and fails with the
above error every time. Since the regular stuff (not the new gtk2 stuff) builds
fine, it is now masked in portage until the gtk2 issue can be resolved. To
install, just:
# echo "net-p2p/mldonkey" >> /etc/portage/package.unmask
and you should be able to upgrade without problem. Note the gtk2-goodness is
commented out until it behaves correctly. I'd like to get gtk2 working before
we push it even to the testing branches.
Comment 19 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-04 01:57:30 UTC
I'm sorry for my last post ;-) I read some info about lablgtk and what I wrote is .... big piss of crap.

Sorry!

Regards,
Przemek
Comment 20 Carsten Lohrke (RETIRED) gentoo-dev 2004-08-04 05:41:15 UTC
The gtk dependency is wrong btw.. The gtk use flag does not mean gtk 1, but gtk (1 || 2), which means if USE="-gtk gtk2" then neither gtk1 nor gtk2 should be supported. This is a backwards compatibility thing irrc.

The dependency has to be:

gtk? ( !gtk2? ( =dev-ml/lablgtk-1.2.6* )
       gtk2? ( =dev-ml/lablgtk-2* ) )
Comment 21 Jon Hood (RETIRED) gentoo-dev 2004-08-04 09:43:49 UTC
thank you carlo, that is now fixed in the comments of the masked ebuild in portage :).
Does anyone have a success story with the gtk2 interface they would like to share?
Comment 22 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-04 14:13:56 UTC
Ok. I've found a solution for compiling mldonkey with gtk2.

The problem is that in portage is quite old version ( ;-) ) of lablgtk-2 : 2.2.0 and on http://wwwfun.kurims.kyoto-u.ac.jp/soft/olabl/lablgtk.html there is newer version - 2.4.0 .

With version 2.4.0 gtk2 support for mldonkey is compilling and running with no problems.

I think that we need a newer version of lablgtk in portage and - of course:
gtk? ( !gtk2? ( =dev-ml/lablgtk-1.2.6* )
       gtk2? ( >=dev-ml/lablgtk-2.4 ) )

Ebuild for lablgtk-2.2.0 working fine with 2.4.0 after renaming.

PS. Sorry for my english - still learning! ;-)

Regards,
Przemek
Comment 23 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-04 14:18:51 UTC
Request for lablgtk version bump:
http://bugs.gentoo.org/show_bug.cgi?id=59452

Regards,
Przemek
Comment 24 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-08-04 14:30:07 UTC
Sorry - a small update...

When gtk2 version of mlgui connects to mldonkey server some errors apears.... and app is going down. So - compilling and running works, but not using of it :(

Regards,
Przemek
Comment 25 spiralvoice 2004-08-06 15:52:43 UTC
MLdonkey 2-5-24 is out, unfortunately for the ebuilds there is no tarball...
Comment 26 spiralvoice 2004-08-09 05:11:56 UTC
Please update your ebuilds, my page has moved to http://ftp.berlios.de/pub/mldonkey/spiralvoice/
Comment 27 spiralvoice 2004-08-09 12:15:19 UTC
MLdonkey 2-5-25 is out with lots of bugfixes, unfortunately for the ebuilds there is no tarball...
Comment 28 Jon Hood (RETIRED) gentoo-dev 2004-08-09 19:29:39 UTC
The SRC_URI has been updated to reflect your new mirror, spiralvoice :).
As for the mldonkey bump, a tarball would be preferred...
Comment 29 Ben 2004-08-09 23:58:55 UTC
New Version again. They seem to work quite a lot at the moment to produce a stable build bevor making a tarball to distribute again. 
Comment 30 Ben 2004-08-11 03:16:30 UTC
Another version bump, but still no packed files
Comment 31 Curtis Magyar 2004-08-11 15:14:02 UTC
I sincerely hope everyone realizes that mldonkey version 2.5-2x is the development tree, and should NOT be included in portage.  If it is, it should be in package.mask as is the policy for development branches.  All versions greater than 2.5-16 contain completely rewritten ed2k and overnet modules, and performance is very very poor compared with the stable 2.5-16.  There are also serious Bittorrent bugs that adversely affect their network.


QUOTE from the developer handbook:
There is a difference between using package.mask and ~arch for ebuilds.
The use of ~arch denotes an ebuild requires testing. The use of
package.mask denotes that the application or library itself is deemed
unstable. For example, if gimp-1.2.0 is the stable release from Gimp
developers, and a new bug fix release is available as 1.2.1, then a
developer should mark the ebuild as ~arch for testing in portage because
the release is deemed to be stable. In another example, if Gimp decides
to release an unstable/development series marked as 1.3.0, then these
ebuilds should be put in package.mask because the software itself is of
development quality and is not recommended by the developers for
distribution.
</QUOTE>
 - http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1

Please don't break my Gentoo again.
Comment 32 Jon Hood (RETIRED) gentoo-dev 2004-08-11 16:17:50 UTC
When I took over net-p2p, the testing branch was already in portage. I got on to an arch dev earlier for marking a >.16 release stable on the arch he maintained, but he did have a good reason for it. Due to coming in to a situation like this, I had to find a mldonkey version that worked (at least for the most part), and put it in ~x86. If you'll look at package.mask, the most recent version of mldonkey in portage is listed because of the reasons you pointed out. If the ~unstable version of mldonkey is broken in any way, please report bugs on it.
Comment 33 Curtis Magyar 2004-08-12 01:39:51 UTC
The bugs are reported on mldonkey's Savannah bug tracker.

http://savannah.nongnu.org/bugs/?group=mldonkey

If there's a version unmasked in portage greater than 2.5-16, then thats the bug that I'm reporting here.  I've been discussing this with Spiralvoice on the mldonkey mailing list, and he's under the impression that having users using the devel tree is beneficial to the mldonkey developers somehow, thats why he is making announcements here.  The job of a distro isn't to provide beta testers though.  Masking the latest version does no good, because 2.5-21 and and 2.5-22 perform much worse than 2.5-27.  We should stick to 2.5-16 until the project stabilizes.

As it stands right now though, 2.5.16-r8 is the best release out there, and its not the latest unmasked version.  At least it wasn't after my last rsync.
Comment 34 Xake 2004-08-12 05:39:50 UTC
I have to agree with cumagyar at some point. Maybe place 2.5-2x in package.mask then maybe there mark them as stable?

Why this behaivor?
In a discussion lately about having evolution 1.5x in portage the conclusion became: If the maintainer of the ebuilds thinks he has the time for it then he can place ebuilds for unstable packages (like the gentoo KDE-team having beta-releases in portage), else he does not have to. Apperently squinky86 thinks he has the time and then he could (and I would like that as I had some problems with 2.5-16 witch I do not have with 2.5-2x) and then maybe they should be placed in packages.mask so anyone does not use it (some noobs easily does use ~arch it seems) but we that likes it and thinks we can handle it may do. And there mark the versions of 2.5-2x that works as stable becouse it apperently does not breake too much.
Comment 35 Jon Hood (RETIRED) gentoo-dev 2004-08-12 17:10:04 UTC
*** Bug 60187 has been marked as a duplicate of this bug. ***
Comment 36 Jon Hood (RETIRED) gentoo-dev 2004-08-13 10:22:45 UTC
Kalle: in order to do this, we would need the hppa port to mark one of the .16 ebuilds as stable on their architecture, then we'd be able to keep the development branch in package.mask correctly. If a 2.6_pre or 2.5.2* tarball is stable enough, it should go into ~testing.
Comment 37 spiralvoice 2004-08-13 10:36:21 UTC
Tarball of CVS 2-5-27 is (temporary) online: http://ftp.berlios.de/pub/mldonkey/spiralvoice/cvs/
Comment 38 spiralvoice 2004-08-13 11:15:48 UTC
Experimental Patchpack 2-5-27b is online:
http://download.berlios.de/pub/mldonkey/spiralvoice/patchpacks/patch_pack27b.gz
There is now a distrib/Changelog_spiralvoice file with infos about the patchpack.
Comment 39 Jon Hood (RETIRED) gentoo-dev 2004-08-13 15:44:31 UTC
Now masked in portage. I am really enjoying this version and would like to unmask it if no one has any objections? I have had it running for a few hours now.
Comment 40 Curtis Magyar 2004-08-13 16:27:20 UTC
Created attachment 37385 [details]
Experimental CVS ebuild for 2.5.27 w/ spiralvoice patchpack 27b

What if we handle the 2.5.2x ebuild like this, and packag.mask it?

It fails if X11 forwarding is enabled by default in /etc/ssh/ssh_config though,
because it creates ~/.xauth* outside the sandbox.  Anyone know how to fix that?
Comment 41 Jon Hood (RETIRED) gentoo-dev 2004-08-13 17:26:05 UTC
I can maintain these development releases, but in my preference and the preference of most other devs, a tarball is prefered over cvs checkouts. What's wrong with the ebuild now in portage?
Comment 42 Curtis Magyar 2004-08-13 18:39:32 UTC
I had made this ebuild before the tarball was available, I thought it might be useful.  It may be useful if tarballs aren't available for a while again.  It extracts the release and patchpack name from $PV, so it should be pretty resilient to version bumps.  I just should have included a version number after the _p I guess, because the ebuild howto says not to rely on a trailing letter to bump the version.

Or you can comment ECVS_CO_OPTS, and try CVS head any time you want, though the patchpack may or may not apply.
Comment 43 Gustavo Zacarias (RETIRED) gentoo-dev 2004-08-14 05:15:11 UTC
squinky, remember to bump RDEPEND to ocaml-3.08 which 2.5.27 seems to require :)
Comment 44 Xake 2004-08-14 07:10:11 UTC
squinky: can you please make the gtk2 useflag depend on the gtk useflag?
It should ONLY look the gtk2 useflag IF the gtk useflag is set, i.e. USE="-gtk" == no gtk at all (no gtk, no gtk2).
Comment 45 Jon Hood (RETIRED) gentoo-dev 2004-08-14 08:07:47 UTC
thanks Kalle and Gustavo, fixed in portage :)
Comment 46 Ben 2004-08-16 09:40:40 UTC
Its seens like the incoming directry setting is not working in the lateste build 2.5.27. All downloads now go into /home/p2p/.mldonkey/shared/.

If you try to set this to another directory with the old ini setting it will just delete the info. Didnt finde out if this is because of the patchset or because of some changes in the version.

Does anybody else have this problem.
Comment 47 Curtis Magyar 2004-08-16 11:08:13 UTC
Believe it or not, thats a feature - not a bug.

Its related to this experimental patch in the Spiralvoice patchpack:

http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=2826

I took a look for the Changelog_spiralvoice in /usr/share/doc/mldonkey*, and couldn't find it.  Perhaps its installation needs to be added to ebuild?

distrib/Changelog_spiralvoice in the patched source.
Comment 48 Xake 2004-08-16 11:55:27 UTC
Could that patch be the reason my mldonkey does not seems to commit properly?

I have "autocommit" and I have two files laying for commitment, one of them have laid in about half a day now. And pressing the commit-button (did it some hours and 1 restart ago) does not help. My system has been restarted two times since the file was completed, and usually my mldonkey have no file for commitment after a restart.
Comment 49 Xake 2004-08-16 12:00:18 UTC
Heh. Found the reason. mldonkey did not have write-permission to the "new" destdir. 
Anyway I don't think the./incoming should be by this patch removed from the shared-list, but be somehow set to the default download-dir (as it more or less automaticly has the right permission) and then somehow have a message (maybe in the ebuild?) informing the user of the new feature.
Comment 50 Curtis Magyar 2004-08-16 12:32:31 UTC
I don't know, but this kind of thing is the reason 2.5.2x should be masked.  You should expect exactly this kind of changes to occur in a development branch.  If you're going to unmask and use it, you better pay attention to the mailing list, and Savannah patch tracker, because things will change on you as a result of minor version number bumps.
Comment 51 Jon Hood (RETIRED) gentoo-dev 2004-08-16 12:55:53 UTC
I see what you mean there and will not unmask 2.5.27, and I agree 2.5.22* should have been masked, but it was not and then it was marked stable on another architecture. It will be masked as soon as possible. We are working on it. As soon as bug #60390 is resolved, >=2.5.17 will be masked.
Comment 52 Curtis Magyar 2004-08-16 13:22:45 UTC
Thats fine.  No complaints here.  I'm satisfied with the solution, and I think you're doing a great job.