Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588878 - gnome2.eclass src_prepare does not call eapply_user with EAPI=6
Summary: gnome2.eclass src_prepare does not call eapply_user with EAPI=6
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-15 11:24 UTC by Mike Auty (RETIRED)
Modified: 2016-07-15 11:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2016-07-15 11:24:23 UTC
Hiya,

Trying to apply user patches to networkmanager-openvpn-1.2.2 (which is an EAPI=6 ebuild), I found that they would not apply because the gnome2.eclass doesn't call it and seemingly portage doesn't throw an error if other functions are called.

According to [1], eapply_user "must be called from every src_prepare function".  It can be called multiple times without problem to allow for ease of use in eclasses.

Ideally there are two things to be changed for this to be fixed.  Firstly the gnome2.eclass should call eapply_user from src_prepare when EAPI > 5.  Secondly, portage should be investigated to see if it can throw errors when src_prepare does not call eapply_user by the time the phase is finished.  This will catch other eclasses that may not call eapply_user even when they suggest they support EAPI=6.

Mike  5:)

[1] https://devmanual.gentoo.org/ebuild-writing/eapi/
Comment 1 Mike Auty (RETIRED) gentoo-dev 2016-07-15 11:25:48 UTC
CCing dev-portage since a part of fixing this properly would involve portage changes.
Comment 2 Mike Auty (RETIRED) gentoo-dev 2016-07-15 11:30:03 UTC
My bad, it does get called, via xdg_src_prepare which calls the default src_prepare.  Sorry for the spam.  5:(