Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588822 - sys-libs/glibc-2.23: wrong vfork aliases in libpthread.so on sparc & mips
Summary: sys-libs/glibc-2.23: wrong vfork aliases in libpthread.so on sparc & mips
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: MIPS Linux
: Normal normal
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: glibc-2.23
  Show dependency tree
 
Reported: 2016-07-14 13:36 UTC by Joshua Kinard
Modified: 2016-11-12 06:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2016-07-14 13:36:09 UTC
It looks like on MIPS (and maybe SPARC, too), attempting to build sys-libs/glibc-2.23* with gcc-5.4.0 and binutils-2.26.1 yields this error:

/ramfs/portage/cross-mips64-unknown-linux-gnu/glibc-2.23-r2/work/build-n32-mips64-unknown-linux-gnu-nptl/nptl/libpthread.so:(*IND*+0x0): multiple definition of `vfork@GLIBC_2.0'

Debian has similar bug for this issue as #827477.  A patch was sent upstream here:
https://sourceware.org/ml/libc-alpha/2016-06/msg00660.html

If we can get that incorporated into glibc, I can retest to make sure it works for 2.23.  Hopefully that'll go into 2.24 upstream.
Comment 1 Joshua Kinard gentoo-dev 2016-09-05 11:10:59 UTC
Anyone on base-system mind if I roll this patch into the glibc patchset and deploy it to the tree?  Since it fixes an obscure build issue on mips-only, I don't think a revbump is required.  It's becoming a bit of a blocker on mips if I use binutils-2.26.  Otherwise, I'll have to p.mask 2.26 for mips.

That said, where is our procedure for bumping the glibc patches anyways?  they don't appear to have been migrated to git yet, and are still sitting on the old CVS server:
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/glibc/2.23/
Comment 2 Joshua Kinard gentoo-dev 2016-09-05 11:11:17 UTC
Er, not base-system, toolchain.
Comment 3 Vicente Olivert Riera (RETIRED) gentoo-dev 2016-09-12 15:18:00 UTC
I think you need two patches:

https://sourceware.org/git/?p=glibc.git;a=commit;h=43c2948756bb6e144c7b871e827bba37d61ad3a3
https://sourceware.org/git/?p=glibc.git;a=commit;h=b87c1ec3fa398646f042a68f0ce0f7d09c1348c7

And tweak them in order to not patch the ChangeLog so they can apply cleanly.
Comment 4 Joshua Kinard gentoo-dev 2016-09-13 14:35:47 UTC
(In reply to Vicente Olivert Riera from comment #3)
> I think you need two patches:
> 
> https://sourceware.org/git/?p=glibc.git;a=commit;
> h=43c2948756bb6e144c7b871e827bba37d61ad3a3
> https://sourceware.org/git/?p=glibc.git;a=commit;
> h=b87c1ec3fa398646f042a68f0ce0f7d09c1348c7
> 
> And tweak them in order to not patch the ChangeLog so they can apply cleanly.

Seems easy enough.  It looks like Mike has been maintaining the glibc patches in the old CVS repo and hasn't migrated them to git yet.  I'd like to get a hold of him and get his okay on moving those to git before making any changes, but he seems to be tied up or something.  Has anyone else heard from him recently?
Comment 5 SpanKY gentoo-dev 2016-11-12 06:29:14 UTC
should be fixed in glibc-2.23-r3