Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588810 - [patch] net-misc/netifrc-0.3.1 bridge: add MTU and iproute2 support
Summary: [patch] net-misc/netifrc-0.3.1 bridge: add MTU and iproute2 support
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: netifrc Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-07-14 11:15 UTC by Denis Kaganovich
Modified: 2016-07-15 14:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
netifrc: iproute2 & MTU for bridges (netifrc-bridge-iproute2.patch,1.66 KB, patch)
2016-07-14 11:17 UTC, Denis Kaganovich 		Details | Diff
netifrc-0.4.0: iproute2 & MTU for bridges (netifrc-bridge-iproute2-4.patch,1.02 KB, patch)
2016-07-15 12:16 UTC, Denis Kaganovich 		Details | Diff
netifrc-0.4.0: iproute2 & MTU for bridges fixed (netifrc-bridge-iproute2-4-2.patch,1.22 KB, patch)
2016-07-15 12:26 UTC, Denis Kaganovich 		Details | Diff
netifrc-0.4.0: MTU for bridges (netifrc-bridge-iproute2-4-2.patch,1.22 KB, patch)
2016-07-15 14:17 UTC, Denis Kaganovich 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Kaganovich 2016-07-14 11:15:46 UTC 
Bridge can be managed by "ip" from iproute2. And even this is single (known to me) way to set bridge MTU (only on "ip link create"). My patch conservative keep brctl where possible (if present and no MTU).

Reproducible: Always
Comment 1 Denis Kaganovich 2016-07-14 11:17:14 UTC 
Created attachment 440668 [details, diff]
netifrc: iproute2 & MTU for bridges
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-07-14 19:28:58 UTC 
Please don't patch the last stable version, but rather look at what's already in Git.

Wherein you'll see that iproute2 has been supported for more than 6 months.
Your mtu change should also not be needed, as the regular mtu handling of iproute2 should be sufficient.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-07-14 19:49:49 UTC 
0.4.0 is out now, test that, the base MTU functionality should just work.
Comment 4 Denis Kaganovich 2016-07-15 12:15:12 UTC 
No. "Base MTU functionality" not working in current kernels (now - 4.6.3). Can look Google about people question too. It work only on interface creation (not change) - "ip link add". But in 0.4.0 patch more simple (and now respect config_vars).
Comment 5 Denis Kaganovich 2016-07-15 12:16:12 UTC 
Created attachment 440760 [details, diff]
netifrc-0.4.0: iproute2 & MTU for bridges
Comment 6 Denis Kaganovich 2016-07-15 12:22:59 UTC 
PS Just try to create bridge and change mtu to jumbo 9000. And then try to create with mtu 9000 from scratch.
Comment 7 Denis Kaganovich 2016-07-15 12:26:56 UTC 
Created attachment 440764 [details, diff]
netifrc-0.4.0: iproute2 & MTU for bridges fixed

just add "mtu" to "local"
Comment 8 Denis Kaganovich 2016-07-15 12:27:42 UTC 
PPS Comment ("iproute2") just dummy copied, sorry.
Comment 9 Denis Kaganovich 2016-07-15 14:17:43 UTC 
Created attachment 440766 [details, diff]
netifrc-0.4.0: MTU for bridges

omg sorry, src/dst patch path... many jobs, many mistakes...
Comment 10 Denis Kaganovich 2016-07-15 14:20:05 UTC 
shit. fix path, yourself you are not dummy...