Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588762 - media-plugins/gst-plugins-meta: allow media-plugins/gst-plugins-mpg123 to provide mp3 support
Summary: media-plugins/gst-plugins-meta: allow media-plugins/gst-plugins-mpg123 to pro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on: 558444
Blocks:
  Show dependency tree
 
Reported: 2016-07-13 16:51 UTC by Coacher
Modified: 2017-02-16 11:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gst-plugins-meta-1.6.3.ebuild (gst-plugins-meta-1.6.3.ebuild,3.76 KB, text/plain)
2016-07-20 17:36 UTC, Coacher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-07-13 16:51:30 UTC
Hello.

Having 'mp3' USE on gst-plugins-meta with description 'Add support for reading mp3 files' is misleading. One can still playback mp3 files through GStreamer even with gst-plugins-meta[-mp3].

'mp3' USE just pulls a plugin that relies on libmad for mp3 decoding. Thus 'mp3' USE should be renamed to 'mad' to reflect the fact that it doesn't enable mp3 support for gstreamer, but only enables mp3 support via specific library.

Please fix.
Comment 1 Pacho Ramos gentoo-dev 2016-07-14 10:12:22 UTC
I agree with leio opinion on this instead:
https://bugs.gentoo.org/show_bug.cgi?id=558444#c16

From my point of view this would be wontfix then
Comment 2 Mart Raudsepp gentoo-dev 2016-07-14 11:14:57 UTC
ah, didn't realize this was entered as a new bug meanwhile before writing my "essay" on the topic :D
I actually saw mgorny poke sound@ just a couple days ago on IRC about killing IUSE=mad everywhere and unifying on mp3 feature USE flag, as it's in the vast majority of cases just used for "support mp3" feature, only two packages had both mad and mp3 IUSE.
Comment 3 Mart Raudsepp gentoo-dev 2016-07-14 13:20:13 UTC
One option could be something like
mp3? ( || ( media-plugins/gst-plugins-mad media-plugins/gst-plugins-mpg123 ) )
so it would pull in mad if neither is installed yet, but not if gst-plugins-mpg123 is installed by user.
I don't think we can comfortably add gst-plugins-libav to this list, as then it would always be satisfied due to other codecs anyway, and I don't think gstreamer avdec_mp3 is that good compared to the others, though not sure without further research.

I guess we can wait a bit on the decision, as we don't even have -mpg123 in yet and maybe there will be other stuff to tweak in the meta soon too to do in one revbump.
Comment 4 Coacher 2016-07-15 10:00:43 UTC
The main reason why I opened this bug is that having gst-plugins-meta[-mp3] and gst-plugins-mpg123 installed simultaneously to get mp3 support is illogical IMHO.

Having mp3? ( || ( media-plugins/gst-plugins-mad media-plugins/gst-plugins-mpg123 ) ) is absolutely fine with me if there are plans to drop global mad USE.
Comment 5 Coacher 2016-07-20 17:36:57 UTC
Created attachment 441236 [details]
gst-plugins-meta-1.6.3.ebuild

Meta ebuild that allows both mad and mpg123 wrt https://bugs.gentoo.org/show_bug.cgi?id=558444#c25
Comment 6 Pacho Ramos gentoo-dev 2016-07-24 12:58:26 UTC
I have no problems with adding the || ( ) dep and allow both to provide mp3 support ;)
Comment 7 Mart Raudsepp gentoo-dev 2017-02-15 21:38:19 UTC
commit 759b7f3f8da78eba331cf6293f460ea7b2840efe
Author: Mart Raudsepp <leio@gentoo.org>
Date:   Wed Feb 15 23:11:51 2017 +0200

    media-plugins/gst-plugins-meta: bump to 1.10.3, allow gst-plugins-mpg123 as USE=mp3 provider
    
    Gentoo-bug: 588762
Comment 8 Coacher 2017-02-16 11:58:51 UTC
Finally! Thank you very much!