588666 – app-admin/hddtemp - the update-hddtemp.db script downloads an old version of hddgentoo.db

Bug 588666 - app-admin/hddtemp - the update-hddtemp.db script downloads an old version of hddgentoo.db

Summary: app-admin/hddtemp - the update-hddtemp.db script downloads an old version of ...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Amadeusz Żołnowski (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-07-12 09:35 UTC by Paolo Pedroni
Modified:	2016-07-20 21:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
hddtemp-fix-588666-574090.patch (hddtemp-fix-588666-574090.patch,15.60 KB, patch) 2016-07-12 10:34 UTC, Paolo Pedroni	Details \| Diff
hddtemp-fix-588666-574090.patch (hddtemp-fix-588666-574090.patch,10.86 KB, patch) 2016-07-12 10:35 UTC, Paolo Pedroni	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paolo Pedroni 2016-07-12 09:35:01 UTC

As in summary:

the script downloads the file at <http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/hddtemp/files/hddgentoo.db>, which is outdated and does not contain the drives added in the latest bugs.

It should probably be updated to download from gitweb.gentoo.org.

Comment 1 Paolo Pedroni 2016-07-12 10:34:04 UTC

Created attachment 440436 [details, diff]
hddtemp-fix-588666-574090.patch

Quick and dirty patch to fix current bug, also fixes bug #574090 and removes old.

Comment 2 Paolo Pedroni 2016-07-12 10:35:35 UTC

Created attachment 440438 [details, diff]
hddtemp-fix-588666-574090.patch

Oops, wrong patch version. Current one is right.

Comment 3 Paolo Pedroni 2016-07-12 10:37:41 UTC

Would you rather have a github PR?

Comment 4 Amadeusz Żołnowski (RETIRED) gentoo-dev

2016-07-20 21:16:28 UTC

Thanks! Fixed.

There was no need to have a second version of this script as update-hddtemp.db-1 and therefore there was no need to update ebuild, just bump to force update for users.