Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588278 - net-misc/networkmanager-1.2.2 - nm-sleep-monitor-upower.c:132:45: error: expected declaration specifiers or '...' before 'nm_sleep_monitor_get'
Summary: net-misc/networkmanager-1.2.2 - nm-sleep-monitor-upower.c:132:45: error: expe...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 588338 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-08 02:01 UTC by jorgicio
Modified: 2016-07-08 20:56 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
The build.log (build-networkmanager.log.gz,47.65 KB, application/gzip)
2016-07-08 02:02 UTC, jorgicio 		Details
The patch that fixes the problem (networkmanager-1.2.2-sleep-monitor-upower_include.patch,872 bytes, patch)
2016-07-08 05:50 UTC, jorgicio 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jorgicio 2016-07-08 02:01:58 UTC 
This happens when I try to build that version of NetworkManager. I'll attach a file then.

Thanks.

Reproducible: Always
Comment 1 jorgicio 2016-07-08 02:02:30 UTC 
Created attachment 440012 [details]
The build.log
Comment 2 jorgicio 2016-07-08 05:50:48 UTC 
Created attachment 440016 [details, diff]
The patch that fixes the problem

I found that patch, tried it and working fine with upower enabled.
Comment 3 Toralf Förster gentoo-dev 2016-07-08 07:45:43 UTC 
Hhm, the attachment seems to be compressed using compress, not gzip.
Comment 4 Miroslav Šulc gentoo-dev 2016-07-08 09:11:06 UTC 
i can confirm the patch fixes the issue
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2016-07-08 10:13:09 UTC 
Should be okay to commit without revbump due to build failure on affected systems. Gnome herd, will you do the honours or shall I?
Comment 6 rtlanceroad 2016-07-08 13:54:09 UTC 
(In reply to Tony Vroon from comment #5)
> Should be okay to commit without revbump due to build failure on affected
> systems. Gnome herd, will you do the honours or shall I?

Tony Vroon, please.
Comment 7 Brian Evans (RETIRED) gentoo-dev 2016-07-08 16:27:18 UTC 
*** Bug 588338 has been marked as a duplicate of this bug. ***
Comment 9 Oleh 2016-07-08 19:49:43 UTC 
upstream patch fixes. please, add.
Comment 10 Alexandre Rostovtsev (RETIRED) gentoo-dev 2016-07-08 20:56:24 UTC 
The build failure only happened if USE="-systemd". So of course both the networkmanager upstream developers and the gentoo gnome team didn't notice any problems in testing; because why would someone want to disable systemd? :)

Fixed in git without a revbump: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dc98b75db10d30cc56d89e9b4188cb68b71cd6c