Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588252 - [vmware] app-emulation/vmware-tools-10.1.6.5214329 : underscore character is reserved for / VMWARE_GUEST not listed as USE_EXPAND variable
Summary: [vmware] app-emulation/vmware-tools-10.1.6.5214329 : underscore character is ...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-07 17:23 UTC by Ulrich Müller
Modified: 2019-02-15 19:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2016-07-07 17:23:52 UTC
There is a vmware_guest.desc file, but VMWARE_GUEST is not listed as a USE_EXPAND variable in {base,embedded}/make.defaults.
Comment 1 Manfred Knick 2017-07-07 22:38:52 UTC
REFERENCE:

Bug 616958 :  12.5.7 version bump

including  app-emulation/vmware-tools-10.1.6.5214329


I'm using

# grep -R -i "VMWARE_GUEST" /etc/portage/*

  /etc/portage/package.use:
     app-emulation/vmware-tools
     vmware_guest_freebsd
     vmware_guest_linux
     vmware_guest_solaris
     vmware_guest_windows 

with complete satisfaction.

@ Ulrich :

Does your problem still exist?

In case == "Yes":

. . . Would you be so kind to elaborate. please?
Comment 2 Ulrich Müller gentoo-dev 2017-07-08 06:08:00 UTC
This has nothing to do with user configuration in /etc/portage.

The problem is the missing declaration of a USE_EXPAND variable for vmware_guest_freebsd etc. The underscore character is reserved for USE_EXPAND, therefore these should not be normal USE flags.

Also there is a description in profiles/desc/vmware_guest.desc ("This file contains descriptions of VMWARE_GUEST USE_EXPAND flags."), so I think the intention is clear.
Comment 3 Manfred Knick 2017-07-08 16:14:10 UTC
(In reply to Ulrich Müller from comment #2)

Thank you for your hint!

# grep -R -i "vmware" /usr/portage/profiles/base/*
delivers NONE.

#  find / -name "vmware_guest.desc"
   /usr/portage/profiles/desc/vmware_guest.desc
   /var/lib/layman/vmware/profiles/desc/vmware_guest.desc

"The USE_EXPAND list is set in profiles/base/make.defaults 
 as of Portage 2.0.51.20. 
 This must not be modified without discussion on the gentoo-dev list,  <---!
 and it must not be modified in any subprofile."
[ https://devmanual.gentoo.org/general-concepts/use-flags/ ]

::   DEVs, this is reserved for you ;-)

AFAICR,
    vmware_guest_* has already been used 
    since VMware Workstation 9 at least.

TEST:
   Deleting vmware_guest_* from packge.use
   and adding
   . . . .  VMWARE_GUEST="freebsd linux solaris windows"
   into make.conf instead
does _not_ yield the results one could naively hope for
because it is not incorporated into USE_EXPAND (line 14)
in /usr/portage/profiles/base/make.defaults.

That hopefully having understood correctly now,
two alternatives remain:

  EITHER
    DEVs conclude to incorporate VMWARE_GUEST into USE_EXPAND
         which would be the elegance preferred
         completing existing "vmware_guest.desc"
  OR
    change USE variables to names without "_" in tools ebuild.


(In reply to Ulrich Müller from comment #2)
> The underscore character is reserved for
> USE_EXPAND

@ Ulrich:

To me it seems there might be multiple other "_" 'culprits' as well:

# grep -i "_" ../package.use | grep -v -i vmware

app-admin/gkrellm		lm_sensors ...
x11-drivers/nvidia-drivers	... -abi_x86_32 ...
x11-proto/xcb-proto		python_targets_python3_4
Comment 4 Manfred Knick 2017-11-30 12:18:40 UTC
VMware Products have been removed from Main Portage Tree during Nov-2017.

Further development has been relegated to [vmware] Overlay.

Situation as of today, 30-Nov-2017:
Workstation : stable in [vmware] = 12.5.8  / released = 14.0.0  : Bug 634770
Player      : stable in [vmware] = 12.5.8  / released = 14.0.0  : Bug 639162
Modules     : stable in [vmware] = 308.5.8 / released = 329.0.0 : Bug 634862
Tools       : stable in [vmware] = 10.1.6  / released = 10.1.15 : Bug 634854


The version in the overlay still uses vmware_* USE flags,
but will EOL soon anyway: 2018/02/25
[ https://bugs.gentoo.org/634770#c14 ] .

The newly proposed version for 14.0 
- obbsoletes the former Tools package,
- does not use any "_" USE flags any more:

# equery uses =app-emulation/vmware-workstation-14.0.0.6661328-r6  | grep vmware
-vmware-tools-darwin
-vmware-tools-darwinPre15
+vmware-tools-freebsd
+vmware-tools-linux
-vmware-tools-linuxPreGlibc25
-vmware-tools-netware
-vmware-tools-solaris
-vmware-tools-winPre2k
-vmware-tools-winPreVista
+vmware-tools-windows
Comment 5 Manfred Knick 2019-02-15 19:23:49 UTC
Very unfortunately,

. . . [vmware-overlay]

had to be been closed down
and was removed from overlays/repositories.xml:

. . . Bug 627666 - vmware: no reply to project status mail

. . . [ https://bugs.gentoo.org/627666#c8 ]


Currently up-to-date and perfectly working versions of vmware-workstation:
c.f.
  - Bug 663670     and
  - Bug 671218


HINT concerning vmware-player:
  - just install above;
  - vmware-player will be included :-)