Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 587872 - games-engines/renpy-6.99.12 version bump request
Summary: games-engines/renpy-6.99.12 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial with 1 vote (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 601200
  Show dependency tree
 
Reported: 2016-07-03 12:25 UTC by Alex
Modified: 2017-07-15 23:26 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated PyGame ebuild (pygame_sdl2-6.99.10.ebuild,747 bytes, text/plain)
2016-07-03 12:25 UTC, Alex
Details
RenPy 6.99.10 updated ebuild (renpy-6.99.10.ebuild,2.48 KB, text/plain)
2016-07-03 12:26 UTC, Alex
Details
Right EBUILD for pygame_sdl2 (pygame_sdl2-6.99.10.ebuild,931 bytes, text/plain)
2016-07-07 11:53 UTC, Alex
Details
multiabi patch for RenPy 6.99.12 (formatting changes from 6.99.10) (renpy-6.99.12-multiple-abi.patch,11.09 KB, patch)
2016-10-14 23:40 UTC, Alex
Details | Diff
multiabi patch for RenPy 6.99.12 (rewritten from 6.99.12) (renpy-6.99.12-multiple-abi.patch,11.67 KB, patch)
2017-02-01 18:31 UTC, Alex
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2016-07-03 12:25:34 UTC
Created attachment 439520 [details]
Updated PyGame ebuild

Updated ebuild for RnPy version 6.99.10 and also PyGame_SDL2 same version
Comment 1 Alex 2016-07-03 12:26:34 UTC
Created attachment 439522 [details]
RenPy 6.99.10 updated ebuild
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2016-07-06 21:33:13 UTC
Updated PyGame ebuild fails since S doesn't exist.
Comment 3 Alex 2016-07-07 11:52:15 UTC
(In reply to Mr. Bones. from comment #2)
> Updated PyGame ebuild fails since S doesn't exist.

Oh, I'm terribly sorry - it's not even the right one. Replaced it.
Comment 4 Alex 2016-07-07 11:53:18 UTC
Created attachment 439946 [details]
Right EBUILD for pygame_sdl2
Comment 5 Alex 2016-10-14 22:46:01 UTC
It's already 6.99.12 release of upstream. Is it so hard to just bump a version?
Comment 6 Alex 2016-10-14 23:40:32 UTC
Created attachment 450238 [details, diff]
multiabi patch for RenPy 6.99.12 (formatting changes from 6.99.10)
Comment 7 Patrice Clement gentoo-dev 2016-10-15 13:18:14 UTC
(In reply to Alex from comment #6)
> Created attachment 450238 [details, diff] [details, diff]
> multiabi patch for RenPy 6.99.12 (formatting changes from 6.99.10)

Hi. The proxy maintainer of this ebuild is AWOL it seems. Would you be interested in taking over maintainership?
Comment 8 Alex 2016-10-16 19:49:28 UTC
(In reply to Patrice Clement from comment #7)
> Hi. The proxy maintainer of this ebuild is AWOL it seems. Would you be
> interested in taking over maintainership?
Well, I don't have much free time and required skills. I'm OK to write and propose my (sometimes ugly) ebuilds, but not ready to be a maintainer.
Comment 9 Pavel Volkov 2016-12-17 12:27:14 UTC
I don't understand which file is what here.

I named your files like so in overlay:
1.  "RenPy 6.99.10 updated ebuild" => "renpy-6.99.12.ebuild".
2. "Right EBUILD for pygame_sdl2" => "pygame_sdl2-6.99.12.ebuild"
3. "multiabi patch for RenPy 6.99.12 (formatting changes from 6.99.10)" => "renpy-6.99.12-multiple-abi.patch"

And the patchs fails with renpy-6.99.12:

checking file renpy.py
Hunk #1 FAILED at 28.
Hunk #2 succeeded at 156 (offset 2 lines).
1 out of 2 hunks FAILED
checking file renpy/common.py
checking file renpy/main.py
Hunk #1 succeeded at 31 with fuzz 2 (offset 4 lines).
Hunk #2 succeeded at 267 (offset -6 lines).
Hunk #3 succeeded at 379 (offset 8 lines).

patch program exited with status 1

What's wrong here?
Comment 10 Alex 2016-12-17 18:02:08 UTC
(In reply to Pavel Volkov from comment #9)
> What's wrong here?

Sorry, but I can't reproduce your issue. Tried to rebuild RenPy and pygame_sdl2, no errors, went flawlessly. Please provide more information and complete build log.
Comment 11 Oliver Freyermuth 2017-02-01 17:39:39 UTC
(In reply to Alex from comment #10)
> Sorry, but I can't reproduce your issue. Tried to rebuild RenPy and
> pygame_sdl2, no errors, went flawlessly. Please provide more information and
> complete build log.

Exactly the same issue here, the patch does not apply against 6.99.12. 
Since the build does not even start, no build log can be included apart from:

* Failed Patch: renpy-6.99.12-multiple-abi.patch !
* ( /usr/local/portage/local/games-engines/renpy/files/renpy-6.99.12-multiple-abi.patch )
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/games-engines/renpy-6.99.12/temp/renpy-6.99.12-multiple-abi.patch.out

The interesting part of "patch.out" was already shown. 

Maybe upstream did something ugly and modified their distfile? 
I have:
$ md5sum /usr/portage/distfiles/renpy-6.99.12-source.tar.bz2 
123826a194a6d2e23b948f5bfda5c46f

And, just for reference, the patch which is also attached to this bug:
$ md5sum /usr/local/portage/local/games-engines/renpy/files/renpy-6.99.12-multiple-abi.patch 
cc6fe39bb53946898165e8ddcde985f9
Comment 12 Alex 2017-02-01 18:30:42 UTC
(In reply to Oliver Freyermuth from comment #11)
> Maybe upstream did something ugly and modified their distfile? 
Nice catch, they are. I just wasn't expecting such dirty trick from them, they changed some source files. Sorry guys, patch now should be fixed. Tried to rebuild against "new" version of 6.99.12 with MD5 123826a194a6d2e23b948f5bfda5c46f, went smoothly.
Comment 13 Alex 2017-02-01 18:31:55 UTC
Created attachment 462112 [details, diff]
multiabi patch for RenPy 6.99.12 (rewritten from 6.99.12)
Comment 14 Tim 2017-03-12 06:13:33 UTC
This is an important fix with the recent gst-plugins updates which all but force a ffmpeg upgrade - none of the old versions of renpy will build. I had to figure out how to create my own local repository to use these sample ebuilds, but they worked perfectly.
Comment 15 Pacho Ramos gentoo-dev 2017-06-17 09:31:03 UTC
either this is finally fixed in the tree or this should be treecleaned
Comment 16 Alex 2017-06-19 09:50:54 UTC
(In reply to Pacho Ramos from comment #15)
> either this is finally fixed in the tree or this should be treecleaned

No, it's not fixed, still unbuildable 6.99.6 in tree. And I can't understand why it's so hard to just bump package version. Well, better is to remove it than have broken version in tree I guess.
Comment 17 Andrew Savchenko gentoo-dev 2017-07-15 23:26:51 UTC
Fixed in commit 9a1bcce1539cf2b1107865cb5b77eb189ac3344c.