Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 587504 - sci-electronics/kicad: suggestions how to improve USE=minimal
Summary: sci-electronics/kicad: suggestions how to improve USE=minimal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-06-29 10:53 UTC by Uladzimir Bely
Modified: 2016-07-24 01:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Improving "minimal" use patch (kicad-4.0.2-r2.diff,1.56 KB, patch)
2016-06-29 15:48 UTC, Uladzimir Bely
Details | Diff
Improve "minimal" use patch (improve-minimal-use.patch,1.25 KB, patch)
2016-07-04 10:21 UTC, Uladzimir Bely
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Uladzimir Bely 2016-06-29 10:53:23 UTC
I prefer to use minimal KiCad installation (USE="minimal -github -webkit) and download component libraries manually using /usr/share/doc/kicad-4.0.2-r2/scripts/library-repos-install.sh.bz2 script. But ebuild could handle minimal configuration better.

First of all, according SRC_URI, "kicad-footprints" tarball is downloaded always, but it's used only with USE=minimal. It would be better to make it dependent on !minimal, like kicad-library tarball

Second, src_prepare() shouldn't totally delete template subdirectory when USE=minimal. There are only 5 small files in it (35KiB), and one of them, kicad.pro is used as a template for new project and KiCad shows messagebox with error without this file.

One more thing is not so related to USE=minimal. Desktop shortcut /usr/share/applications/cvpcb.desktop does nothing and can be deleted

Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2016-06-29 13:56:03 UTC
Uladzimir, thank you for your suggestions how to improve the ebuild.
If you have an ebuild with your suggestions in your local overlay, please attach it here. It will help the maintainer to compare your suggestions with the current ebuild.
Comment 2 Uladzimir Bely 2016-06-29 15:48:14 UTC
Created attachment 439168 [details, diff]
Improving "minimal" use patch

Jonas, I've added patch.
Comment 3 Uladzimir Bely 2016-07-04 10:21:14 UTC
Created attachment 439668 [details, diff]
Improve "minimal" use patch

While default /usr/share/kicad/template/kicad.pro file might not be very useful (it doesn't include all libraries and user should manage his project by himself), maybe minimal installation shouldn't install templates.

So, src_prepare() shouldn't be modified.

Updated patch, which changes ebuild less, is here.
Comment 4 Zoltan Puskas 2016-07-06 22:02:44 UTC
@Uladzimir: thanks for the patch. It looks reasonable, I'll update the ebuild.
Comment 5 Zoltan Puskas 2016-07-24 01:41:39 UTC
commit ed1add145d96a6cebfdbafb3c021d954b1fee9ab
Author: Zoltan Puskas <zoltan@sinustrom.info>
Date:   Mon Jul 11 00:59:39 2016 -0700

    sci-electronics/kicad: Reduce minimal installation, add libressl

    In minimal install do not download footprints source. Add switch
    to build with libressl.

    Gentoo Bugs: #587504, #569764

    Package-Manager: portage-2.3.0