Created attachment 437612 [details] emerge --info reiserfsprogs reiserfsprogs-3.6.25 apparently simply assumes (without checking, no hits for acl in configure) sys-apps/acl is installed, and fails compile step due to missing sys/acl.h (which I correctly guessed acl installs). >>> Compiling source in /tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25 ... make -j10 -l8 Making all in include make[1]: Entering directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/include' make all-am make[2]: Entering directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/include' make[2]: Leaving directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/include' make[1]: Leaving directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/include' Making all in lib make[1]: Entering directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/lib' [...] make[1]: Leaving directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/lib' Making all in reiserfscore make[1]: Entering directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/reiserfscore' [...] /bin/sh ../libtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -march=native -pipe -O2 -frename-registers -fweb -fmerge-all-constants -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -freorder-blocks-and-partition -std=gnu89 -Wno-unused-parameter -Wredundant-decls -Wuninitialized -c -o xattr.lo xattr.c libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -march=native -pipe -O2 -frename-registers -fweb -fmerge-all-constants -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -freorder-blocks-and-partition -std=gnu89 -Wno-unused-parameter -Wredundant-decls -Wuninitialized -c xattr.c -fPIC -DPIC -o .libs/xattr.o xattr.c:4:21: fatal error: sys/acl.h: No such file or directory compilation terminated. make[2]: *** [Makefile:454: xattr.lo] Error 1 make[2]: Leaving directory '/tmp/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/reiserfscore' Sure enough, after manually merging acl, reiserfsprogs builds and merges just fine. So the fat and easy solution would be simply making reiserfsprogs depend on acl, which after all isn't /too/ huge or hard to build, tho obviously a preferred and leaner solution would be an acl USE flag and killing the dep if it's off. Attaching emerge --info reiserfsprogs (after merging acl and 3.6.25). Will attach the full pre-acl-merge failing build log as well.
Created attachment 437614 [details] full failed build log
the sys/acl.h include looks spurious. it can just be deleted. however, the configure script will probe for libuuid & com_err and use it when found. so we'll need to address those deps too.
reiserfsprogs-3.6.25 has been declared stable but this bug is still present. It just failed to compile for me: /bin/sh ../libtool --tag=CC --mode=compile i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -O3 -march=i686 -fomit-frame-pointer -std=gnu89 -Wno-unused-parameter -Wredundant-decls -Wuninitialized -c -o xattr.lo xattr.c libtool: compile: i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -O3 -march=i686 -fomit-frame-pointer -std=gnu89 -Wno-unused-parameter -Wredundant-decls -Wuninitialized -c xattr.c -fPIC -DPIC -o .libs/xattr.o xattr.c:4:21: fatal error: sys/acl.h: No such file or directory compilation terminated. make[2]: *** [Makefile:454: xattr.lo] Error 1 make[2]: Leaving directory '/var/tmp/portage/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/reiserfscore' make[1]: *** [Makefile:341: all] Error 2 make[1]: Leaving directory '/var/tmp/portage/portage/sys-fs/reiserfsprogs-3.6.25/work/reiserfsprogs-3.6.25/reiserfscore' make: *** [Makefile:377: all-recursive] Error 1
Created attachment 480764 [details, diff] Remove #include <sys/acl.h> from reiserfscore/xattr.c Delete a spurious #include <sys/acl.h> to make things compile on systems with no "acl" use flag enabled. Applies to reiserfs-3.6.25 and 3.6.26.
commit 547624bfcfd063cea4c9b7bbabe508a086140f83 (HEAD -> master, origin/master, origin/HEAD) Author: Lars Wendler <polynomial-c@gentoo.org> Date: Wed Jul 5 13:59:00 2017 sys-fs/reiserfsprogs: Don't include sys/acl.h (bug #585978). Package-Manager: Portage-2.3.6, Repoman-2.3.2
(In reply to Lars Wendler (Polynomial-C) from comment #5) > commit 547624bfcfd063cea4c9b7bbabe508a086140f83 (HEAD -> master, > origin/master, origin/HEAD) > Author: Lars Wendler <polynomial-c@gentoo.org> > Date: Wed Jul 5 13:59:00 2017 > > sys-fs/reiserfsprogs: Don't include sys/acl.h (bug #585978). Going thru my old bugs list... Resolved/obsolete, as the above would appear to fix the problem, tho I haven't verified as I switched to btrfs and no longer have reiserfsprogs on my system, so can't really verify fixed.
