Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585362 - sys-apps/ufiformat: UFI USB floppy disk formatter
Summary: sys-apps/ufiformat: UFI USB floppy disk formatter
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2016-06-08 09:11 UTC by Jocelyn Mayer
Modified: 2018-12-21 15:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sys-apps/ufiformat version 0.9.9 ebuild (ufiformat.tar.bz2,1.73 KB, application/x-bzip)
2016-06-08 09:13 UTC, Jocelyn Mayer
Details
New fixed version of ufiformat-0.9.9 ebuild (ufiformat-0.9.9.ebuild,427 bytes, text/plain)
2017-03-17 06:34 UTC, Jocelyn Mayer
Details
Updated ebuild for ufiformat-0.9.9 (ufiformat-0.9.9.ebuild,437 bytes, text/plain)
2018-12-21 15:14 UTC, Richard Ash
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Mayer 2016-06-08 09:11:25 UTC
This application allows one to low-level format a floppy disk using UFI USB protocol.
It can be an useful replacement to fdformat for common PC disk formats, for backward compatibility when one wants to recover / use old floppy disks.
This application has been successfully tested on amd64, ppc and ppc64 machines.

Reproducible: Always

Steps to Reproduce:
1. fdformat do not allow reformating floppy disks using an USB drive

Actual Results:  
# fdformat /dev/sdf
fdformat: could not determine current format type: Invalid argument
# strace fdformat /dev/sdf
execve("/usr/sbin/fdformat", ["fdformat", "/dev/sdf"], [/* 55 vars */]) = 0
brk(0)                                  = 0x606000
[...]
ioctl(3, FDGETPRM, 0x605200)            = -1 EINVAL (Invalid argument)



Expected Results:  
# ufiformat -v /dev/sg6
format on device=/dev/sg6, size=0
geometry: track=80, head=2, sector=18, block=512
done                                   


ufiformat currently only support most common PC formats, ie:
* 640 kiB, 80 tracks, 2 heads, 8 512 bytes sectors per track
* 720 kiB, 80 tracks, 2 heads, 9 512 bytes sectors per track
* 1200 kiB, 80 tracks, 2 heads, 15 512 bytes sectors per track
* 1232 kiB, 77 tracks, 2 heads, 8 1024 bytes sectors per track
* 1440 kiB, 80 tracks, 2 heads, 18 512 bytes sectors per track
It would be trivial to add more formats, following the format table as found in Linux kernel code, and 1 sided floppy disks (I got some of those, from my old Atari ST computer).
Comment 1 Jocelyn Mayer 2016-06-08 09:13:10 UTC
Created attachment 436852 [details]
sys-apps/ufiformat version 0.9.9 ebuild

Here is the ebuild used to merge sys-apps/ufiformat and use it, tested on amd64, ppc and ppc64 machines.
Comment 2 Amy Liffey gentoo-dev 2016-12-17 17:47:18 UTC
Hello,
would you be willing to maintain this package through Proxy Maintainers project?

https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 3 Jocelyn Mayer 2016-12-22 10:12:53 UTC
Hi,
I see no objection doing this package maintenance.
I guess this won't be a huge task as the protocol implementation is quite complete.
I'll be able to get involved starting from 01/2017.
Comment 4 Göktürk Yüksek archtester gentoo-dev 2017-03-16 23:00:54 UTC
Hi,

I'd like to make a few remarks about your submission. They should be addressed before we can proceed further. For future submissions, you don't have to tarball the whole directory, just attaching the ebuild file is enough. Now for the actual submission:

- ${P} and ${MY_P} are the same thing, so ${MY_P} should be removed
- The copyright year on line 1 should reflect 2017
- The license should be GPL-2+, becuse it says GPL-2 or later in the source
- Remove $Header
- Inheriting eutils isn't necessary because this ebuild isn't utilizing any of its functionality.
- KEYWORDS must be fixed. You should only include the architectures that you have successfully tested this package on. I'm guessing that will be amd64 for you. Because this package will be included as "unstable", you need "~amd64" in KEYWORDS. I have an x86 machine that I can test this with if needed.
- You are possibly missing a build time dependency on sys-kernel/linux-headers due to '#include <linux/major.h>' in ufi_detect.c.
- sys-fs/e2fsprogs is a runtime dependency and should be in RDEPEND:
  $ scanelf -n ufiformat 
  TYPE   NEEDED FILE 
  ET_EXEC libext2fs.so.2,libc.so.6 ufiformat
- '|| die' after emake isn't required in EAPI 6, emake calls it internally on failure

Thank you for your interest,
Comment 5 Jocelyn Mayer 2017-03-17 06:34:32 UTC
Created attachment 467288 [details]
New fixed version of ufiformat-0.9.9 ebuild

New version of the ufiformat-0.9.9 ebuild with:
* simplification: remove unneeded MY_P variable
* simplification: remove unneeded eutils inheritance
* simplification: remove unneeded src_install function
* fix copyright year
* fix package license
* fix dependencies
Comment 6 Jocelyn Mayer 2017-03-17 06:40:02 UTC
Thanks for the tips !
I tried to apply all your comments and simplify the ebuild (for example, remove the unneeded src_install function).
Note: this package has been succesfully tested with many floppy disks of different format sizes on the three listed architectures, ie amd64, ppc and ppc64.
I removed x86 from the list, as it's currently untested.
Comment 7 Göktürk Yüksek archtester gentoo-dev 2018-04-04 01:26:28 UTC
@Jocelyn Mayer: I'm sorry that this bug has never received a reply. I am not a member of proxy-maint anymore but they might have been under the impression that I will follow through with the review. If you are still interested, please contact them again.
Comment 8 Richard Ash 2018-12-21 15:14:51 UTC
Created attachment 558316 [details]
Updated ebuild for ufiformat-0.9.9

I've just found this bug, because I wanted to make an Iomega floppy drive work. The upstream package has been moved onto github because geocities.jp is closing.

New ebuild which uses the github URL as source attached, based on the last submission here. Tested on amd64 and x86 machines with an iomega (Citizen Watch according to lsusb) drive.

Signed-off-by: Richard Ash <richard@audacityteam.org>