Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584780 - media-libs/libgphoto2: inconsistent CAMERAS defaults
Summary: media-libs/libgphoto2: inconsistent CAMERAS defaults
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 16:46 UTC by Andrew Savchenko
Modified: 2017-01-22 13:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2016-06-01 16:46:33 UTC
Hi,

all in-tree libgphoto2 versions provide inconsistent approach to IUSE_CAMERAS_* defaults:

1. All cameras are enabled by default:

1.a) This is suggested by the following ebuild comment¹:

 24 # By default, drivers for all supported cameras will be compiled.
 25 # If you want to only compile for specific camera(s), set CAMERAS
 26 # environment to a space-separated list (no commas) of drivers that
 27 # you want to build.

1.b) If not all cameras are enabled, ebuild warns users:

110     if [ "${cam_warn}" = "yes" ]; then
111         [ -z "${cameras}" ] || cameras="${cameras:1}"
112         einfo "Enabled camera drivers: ${cameras:-none}"
113         einfo "Upstream will not support you if you do not compile all camera drivers first"
114     else

This message hints user, that he/she needs to enable all cameras to get supported configuration.

2. But default behaviour is different.

2.a) Only ptp2 is enabled in the profile (/etc/portage/profiles/base/make.defaults):

 55 # Pacho Ramos <pacho@gentoo.org> (14 Feb 2010)
 56 # Enable 'ptp2' by default as it is available for most cameras.
 57 CAMERAS="ptp2"

2.b) cameras are not enabled (+USE) in ebuild:

 48 for camera in ${IUSE_CAMERAS}; do
 49     IUSE="${IUSE} cameras_${camera}"
 50 done


It is possible either keep defaults as is (build only ptp2) or switch to upstream default (build all cameras). I prefer the last, since it is upstream supported and probably what most users want, but it is up to you to decide. Anyway please keep defaults consistent: either remove 1.a comment and provide an easy way to fix 1.b (e.g. USE_CAMERAS=all), or remove 2.a and in 2.b change line 49 to +cameras_ (as well as USE="+gd"). I may prepare patches for either way, if you let me know on your decision.

------------------------------------------------------------------
¹ Here and later lines are sourced from libgphoto2-2.5.10.ebuild.
Comment 1 Pacho Ramos gentoo-dev 2016-12-05 12:25:39 UTC
@gnome, @graphics, what do you prefer? 

I would enable all cameras by default to also cover most hardware and, even, stop trying to show all this warnings as explained at https://bugs.gentoo.org/show_bug.cgi?id=560432#c1 , I have never had any isues with upstream as most of the times the bugs I reported weren't even related with missing cameras support. Also, we (gentoo downstream) as the first "layer" for getting bug reports, should be able to know if people needs to enable all cameras at first or not. I guess upstream suggests to enable all to prevent bug reports about "oh! my camera doesn't work!"
Comment 2 Pacho Ramos gentoo-dev 2017-01-22 13:45:33 UTC
[master e0c0c30] media-libs/libgphoto2: Version bump, enable all CAMERAS by default as it's the upstream recommendation, and also will allow people to get 'just works' experience over trying to dig what concrete CAMERA he/she needs (#584780)
 2 files changed, 209 insertions(+)
 create mode 100644 media-libs/libgphoto2/libgphoto2-2.5.12.ebuild