Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584620 - app-emulation/wine-9999 remove staging patches/useflags
Summary: app-emulation/wine-9999 remove staging patches/useflags
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-30 23:15 UTC by C. Wijtmans
Modified: 2016-05-31 21:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description C. Wijtmans 2016-05-30 23:15:25 UTC
staging patches may not work and fail the ebuild.
Comment 1 Alex Xu (Hello71) 2016-05-30 23:25:46 UTC
by that logic we should not have -9999 ebuilds at all because they "may fail".
Comment 2 C. Wijtmans 2016-05-31 00:00:04 UTC
By that logic we should not have ebuilds at all because they "may fail".
The staging patches dont work on the git. USE flags should be removed.
Comment 3 Adam Feldman gentoo-dev 2016-05-31 01:29:54 UTC
9999s are not ever guaranteed to build, as Hello71 said.
Comment 4 Austin English (RETIRED) gentoo-dev 2016-05-31 06:10:29 UTC
(In reply to NP-Hardass from comment #3)
> 9999s are not ever guaranteed to build, as Hello71 said.

Yes, but wine-staging is also not intended to apply against wine master.
Comment 5 Adam Feldman gentoo-dev 2016-05-31 16:07:33 UTC
Do not change the status of this bug again. Doing so will result in me having you temporarily banned from bugzilla.

9999s are not guaranteed to build or have patches apply to them. 
Staging provides a mechanism to check what the last known commit that it can apply apply against. This cannot be done automatically as this would prevent this ebuild from being live. That would be pseudo snapshot, and after having discussed with QA, that is not possible. However, the ebuild outputs via einfo that commit hash along with the precise command that a user may use to select the last known commit that staging is known to apply upon.

So, not guaranteed to build, and we provide a mechanism to allow the user to build against an older wine commit if they are too impatient to wait for staging to rebase against wine master. 

End of story.
Comment 6 Adam Feldman gentoo-dev 2016-05-31 16:13:59 UTC
(In reply to Austin English from comment #4)
> (In reply to NP-Hardass from comment #3)
> > 9999s are not ever guaranteed to build, as Hello71 said.
> 
> Yes, but wine-staging is also not intended to apply against wine master.

It is, but I'd only guaranteed to apply against the output of the last known good commit. And as already discussed, we can automatically choose that. The user either overrides locally with an env var or waits for a rebase. Same with any other static patch. Either overrides the commit locally with an env var or wait for upstream/downstream to rebase the patch
Comment 7 Adam Feldman gentoo-dev 2016-05-31 16:19:00 UTC
(In reply to NP-Hardass from comment #6)
> (In reply to Austin English from comment #4)
> > (In reply to NP-Hardass from comment #3)
> > > 9999s are not ever guaranteed to build, as Hello71 said.
> > 
> > Yes, but wine-staging is also not intended to apply against wine master.
> 
> It is, but I'd only guaranteed to apply against the output of the last known
> good commit. And as already discussed, we can automatically choose that. The
> user either overrides locally with an env var or waits for a rebase. Same
> with any other static patch. Either overrides the commit locally with an env
> var or wait for upstream/downstream to rebase the patch

Bah, phone autocorrect.
It's only guaranteed
We can't automatically
Comment 8 C. Wijtmans 2016-05-31 17:04:29 UTC
(In reply to NP-Hardass from comment #6)
> (In reply to Austin English from comment #4)
> > (In reply to NP-Hardass from comment #3)
> > > 9999s are not ever guaranteed to build, as Hello71 said.
> > 
> > Yes, but wine-staging is also not intended to apply against wine master.
> 
> It is, but I'd only guaranteed to apply against the output of the last known
> good commit. And as already discussed, we can automatically choose that. The
> user either overrides locally with an env var or waits for a rebase. Same
> with any other static patch. Either overrides the commit locally with an env
> var or wait for upstream/downstream to rebase the patch

So it is but actually in fact it isnt? If someone wants the patches they should just use the release branches.

(In reply to NP-Hardass from comment #5)
> Do not change the status of this bug again. Doing so will result in me having you > temporarily banned from bugzilla.
"hurdur you are disagreeing with me so i mute you."No wonder people leave "gentoo".

This is my bug report. Is there a way to block you of my bug report?
Comment 9 Adam Feldman gentoo-dev 2016-05-31 21:13:28 UTC
(In reply to C.J. Wijtmans from comment #8)
> (In reply to NP-Hardass from comment #6)
> > (In reply to Austin English from comment #4)
> > > (In reply to NP-Hardass from comment #3)
> > > > 9999s are not ever guaranteed to build, as Hello71 said.
> > > 
> > > Yes, but wine-staging is also not intended to apply against wine master.
> > 
> > It is, but I'd only guaranteed to apply against the output of the last known
> > good commit. And as already discussed, we can automatically choose that. The
> > user either overrides locally with an env var or waits for a rebase. Same
> > with any other static patch. Either overrides the commit locally with an env
> > var or wait for upstream/downstream to rebase the patch
> 
> So it is but actually in fact it isnt? If someone wants the patches they
> should just use the release branches.
> 
> (In reply to NP-Hardass from comment #5)
> > Do not change the status of this bug again. Doing so will result in me having you > temporarily banned from bugzilla.
> "hurdur you are disagreeing with me so i mute you."No wonder people leave
> "gentoo".
> 
> This is my bug report. Is there a way to block you of my bug report?

I am the WINE maintainer.  I am the WINE project lead.  It is my bug report to handle.  I gave you the technical answer and set the official status for the bug.  You changing the status back to unconfirmed repeatedly is arguing with that, especially after I told you not to and gave a huge explanation why.  At this point, unless you have something else to contribute, this bug is being marked as completed.  You may post back to bug if you have anything else to add, but do not change the status again.  This is my last warning on that regard.