Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 584128 - media-video/photofilmstrip-2.1.0 fails to save project and overwrites project file: Exception: tostring() has been removed. Please call tobytes()
Summary: media-video/photofilmstrip-2.1.0 fails to save project and overwrites project...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PhobosK
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-25 21:03 UTC by Cyril42e
Modified: 2017-04-10 17:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
backtrace (backtrace.txt,999 bytes, text/plain)
2016-05-25 21:03 UTC, Cyril42e
Details
photofilmstrip-2.1.0_pillow-3_tostring.patch (photofilmstrip-2.1.0_pillow-3_tostring.patch,1.72 KB, patch)
2016-05-25 21:05 UTC, Cyril42e
Details | Diff
photofilmstrip-2.1.0-r1.ebuild.patch (photofilmstrip-2.1.0-r1.ebuild.patch,455 bytes, patch)
2016-05-30 18:29 UTC, PhobosK
Details | Diff
photofilmstrip-2.1.0-PIL_tostring_fix.patch (photofilmstrip-2.1.0-PIL_tostring_fix.patch,1.40 KB, patch)
2016-05-30 18:31 UTC, PhobosK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cyril42e 2016-05-25 21:03:20 UTC
Created attachment 435378 [details]
backtrace

Photofilmstrip fails when saving a project (see attached backtrace), and overwrites the project file with an empty one:

Exception: tostring() has been removed. Please call tobytes()

This is because since switch from virtual/python-imaging to dev-python/pillow, functions tostring and fromstring have been removed, and should be replaced by tobytes and frombytes.

Attached a patch that can be applied from the ebuild that fixes all calls in the program.
Comment 1 Cyril42e 2016-05-25 21:05:34 UTC
Created attachment 435388 [details, diff]
photofilmstrip-2.1.0_pillow-3_tostring.patch
Comment 2 PhobosK 2016-05-30 18:29:41 UTC
Created attachment 435856 [details, diff]
photofilmstrip-2.1.0-r1.ebuild.patch

Thanks @Cyril42e :)
I've added the patch to a new revision of the ebuild....

Please let some dev upload it to portage tree :)

Thanks
Comment 3 PhobosK 2016-05-30 18:31:24 UTC
Created attachment 435858 [details, diff]
photofilmstrip-2.1.0-PIL_tostring_fix.patch

The added to the ebuild patch...
Comment 4 Göktürk Yüksek archtester gentoo-dev 2017-04-10 17:24:44 UTC
commit 9de54ce8fad5b6aeb7d5b8da6115ae50f8cfee00
Author:     PhobosK <phobosk@fastmail.fm>
AuthorDate: Mon Apr 10 13:21:08 2017 -0400
Commit:     Göktürk Yüksek <gokturk@gentoo.org>
CommitDate: Mon Apr 10 13:23:57 2017 -0400

    media-video/photofilmstrip: fix tostring() runtime exception #584128
    
    Thanks to Cyril42e for the initial patch.
    
    Package-Manager: Portage-2.3.3, Repoman-2.3.2