Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 583994 - media-sound/abcde-2.7 cover art patch
Summary: media-sound/abcde-2.7 cover art patch
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL: http://abcde.einval.com/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 16:26 UTC by Scott Jones
Modified: 2019-04-27 18:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for abcde-2.7.x ebuilds (abcde-2.7_coverart.patch,1.04 KB, patch)
2016-05-24 16:31 UTC, Scott Jones
Details | Diff
add useflag "cover" and "X" to abcde (file_583994.txt,955 bytes, patch)
2017-07-23 08:46 UTC, tk+gentoo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Jones 2016-05-24 16:26:35 UTC
Beginning with version 2.7, abcde has supported cover art.  The attached patch adds two global USE flags (X and cover), as well as their dependencies.

From what I've read, you need to use the musicbrainz cddb to get the meta id's that it needs to grab the cover art.  The "CDDBMETHOD" value would need to be updated in ~/.abcde.conf

abcde tries different methods to find a cover image and falls back to glyr if nothing else works.  The cover art will be displayed using 'display' (from ImageMagick), if the 'X' use flag is enabled.  Fetching the cover art will still work if X is not enabled.. so it can be run on a headless server, etc...

The two packages that can get installed (USE flag dependent):
media-libs/glyr
media-gfx/imagemagick

The one caveat I've found is that abcde doesn't appear to properly parse the metadata from musicbrainz.. but does still grab them (including the cover art info).  I've had to modify all the track names, and artist name after as they contain extra characters.  When using freedb.org's cddb (default) I've had no issues with the metadata.  I'm fairly certain this is a pre-existing bug when just using the musicbrainz USE flag... and using that as the cddb.

Reproducible: Always
Comment 1 Scott Jones 2016-05-24 16:31:31 UTC
Created attachment 435266 [details, diff]
patch for abcde-2.7.x ebuilds

This patch is to patch the media-sound/abcde-2.7.x ebuilds.  I've tested on 9 cd's with abcde-2.7.2, but will patch abcde-2.7.1 as well.
Comment 2 Scott Jones 2016-05-24 16:34:12 UTC
The guide I followed for this, which also has more 'expert' parts for tweaking cover art gets:
http://www.andrews-corner.org/getalbumart.html
Comment 3 Scott Jones 2016-05-24 16:39:31 UTC
Sorry for so many comments... I forgot another part that the abcde configuration needs in order to grab cover art (explained in the guide url in the above comment).

To summarize all that's needed in the local (or global) abcde config:
CDDBMETHOD=musicbrainz
ACTIONS=cddb,read,getalbumart,encode,tag,move,clean

The 'getalbumart' in the ACTIONS variable is what triggers... eh, getting the album art.
Comment 4 tk+gentoo 2017-07-23 08:45:36 UTC
This is still valid for 2.8.1.

However, as I understand the documentation, that downloading album art works even if cddb is used. So the second part of the patch might be redundant.
Comment 5 tk+gentoo 2017-07-23 08:46:49 UTC
Created attachment 486496 [details, diff]
add useflag "cover" and "X" to abcde
Comment 6 Andreas Thalhammer 2019-04-27 18:18:56 UTC
I recently updated abcde. I don't know which version I used before. This is the current one:
[ebuild   R    ] media-sound/abcde-2.8.1::gentoo  USE="aac cdparanoia cdr flac id3tag lame musicbrainz normalize opus replaygain speex vorbis -mac -musepack -wavpack"

I didn't touch my ~/.abcde.conf if that's important.
Trying to use abcde today, I got this error message:
----------snap----------
which: no glyrc in (/usr/lib/llvm/8/bin:/opt/stuffit/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/games/bin)
[ERROR] abcde: glyrc is not in your path.
[INFO] Define the full path to the executable if it exists on your system.
----------snap----------

I installed glyr manually and afterwards it worked:
[ebuild  N     ] media-libs/glyr-1.0.10::gentoo

Question: shouldn't abcde depend on glyr, if it doesn't run without it? Or is my .abcde.conf wrong after the update?

BTW, in /usr/share/doc/abcde-2.8.1/FAQ.bz2 one can read: "If 1 and 2 fail or CDDBMETHOD is cddb the album art will be downloaded using glyrc by artist + album title" and "You will need to install your distro's package of glyr..."

My CDDBMETHOD is cddb, after musicbrainz gave me trouble in previous abcde versions. Since there is no useflag for this, maybe depending on glyr could be made mandatory anyways...