Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 583836 - media-gfx/imv: test/loader.c:4:20: fatal error: cmocka.h: No such file or directory
Summary: media-gfx/imv: test/loader.c:4:20: fatal error: cmocka.h: No such file or dir...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mykyta Holubakha
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 05:55 UTC by Göktürk Yüksek
Modified: 2016-06-04 13:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Göktürk Yüksek archtester gentoo-dev 2016-05-23 05:55:22 UTC 
This package is missing a dependency for the test phase.

$ ebuild imv-2.1.0.ebuild clean cleanrm test
Appending /home/gokturk/stuff/gentoo to PORTDIR_OVERLAY...
Forcing test.
 * imv-2.1.0.tar.gz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                         [ ok ]
>>> Unpacking source...
>>> Unpacking imv-2.1.0.tar.gz to /var/tmp/portage/media-gfx/imv-2.1.0/work
>>> Source unpacked in /var/tmp/portage/media-gfx/imv-2.1.0/work
>>> Preparing source in /var/tmp/portage/media-gfx/imv-2.1.0/work/imv-2.1.0 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-gfx/imv-2.1.0/work/imv-2.1.0 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/media-gfx/imv-2.1.0/work/imv-2.1.0 ...
make -j2 
COMPILING build/texture.o
COMPILING build/loader.o
COMPILING build/viewport.o
COMPILING build/main.o
COMPILING build/util.o
COMPILING build/navigator.o
LINKING build/imv
>>> Source compiled.
>>> Test phase: media-gfx/imv-2.1.0
make -j2   check
BUILDING build/test_loader
BUILDING build/test_navigator
test/loader.c:4:20: fatal error: cmocka.h: No such file or directory
 #include <cmocka.h>
                    ^
compilation terminated.
test/navigator.c:7:20: fatal error: cmocka.h: No such file or directory
 #include <cmocka.h>
                    ^
compilation terminated.
Makefile:50: recipe for target 'build/test_navigator' failed
make: *** [build/test_navigator] Error 1
make: *** Waiting for unfinished jobs....
Makefile:50: recipe for target 'build/test_loader' failed
make: *** [build/test_loader] Error 1
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2016-05-24 01:22:49 UTC 
While I can replicate this, the point is that the test phase was never made part of the ebuild. Wherever the test run is being directed from, it is not in a test phase in the ebuild. Granted, one could be added.
Comment 2 Göktürk Yüksek archtester gentoo-dev 2016-05-24 01:32:26 UTC 
(In reply to Ian Delaney from comment #1)
> While I can replicate this, the point is that the test phase was never made
> part of the ebuild. Wherever the test run is being directed from, it is not
> in a test phase in the ebuild. Granted, one could be added.

Per PMS [0]:

""""
The default implementation used when the ebuild lacks the src_test function must, if tests are enabled, run emake check if and only if such a target is available, or if not run emake test if and only if such a target is available.
[...snip...]

The src_test function may be disabled by RESTRICT.
"""

In this case, there is a 'check' target available and the default implementation is calling that. If tests are not to be utilized, I think they should be disabled with RESTRICT.

[0] https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-1030009.1.8