Bug 583732 – sys-apps/sed: bump to EAPI=5 and support Prefix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benda Xu 2016-05-22 01:12:48 UTC]

Please review the patch, thanks.

Reproducible: Always

[Comment 1 Benda Xu 2016-05-22 01:14:10 UTC]

Created attachment 434926 [details, diff]
sed-4.2.2.patch

By default bindir=${exec-prefix}/bin, so using exec-prefix is a more consistent way.

[Comment 2 Benda Xu 2016-05-22 01:15:17 UTC]

Hi, Mike.  I tried to avoid EAPI=6 at the moment. I think it is okay to bump to EAPI=5.

[Comment 3 Benda Xu 2016-05-22 01:21:51 UTC]

Created attachment 434928 [details, diff]
sed-4.2.2.patch

Leverage usex.

[Comment 4 Benda Xu 2016-05-22 01:22:31 UTC]

Created attachment 434930 [details, diff]
sed-4.2.2.patch

[Comment 5 Benda Xu 2016-05-22 01:23:39 UTC]

Created attachment 434932 [details, diff]
sed-4.2.2.patch

[Comment 6 SpanKY 2016-05-22 02:40:38 UTC]

Comment on attachment 434932 [details, diff]
sed-4.2.2.patch

looks mostly fine.  switch myconf into an array rather than using usex though.

  if use userland_GNU ; then
    myconf+=( --exec-prefix="${EPREFIX}" )
  else
    myconf+=( --program-prefix=g")
  fi

[Comment 7 Benda Xu 2016-06-10 03:48:17 UTC]

Created attachment 437032 [details, diff]
sed-4.2.2.patch

use myconf array.

[Comment 8 SpanKY 2016-06-10 05:26:25 UTC]

(In reply to Benda Xu from comment #7)

lgtm; go for it !

[Comment 9 Benda Xu 2016-06-10 07:22:16 UTC]

Landed: 

  https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43115ed54fa6291626dc2

Thanks, Mike!