Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 583404 - ebuild-maintenance: Add news items to agenda for package moves
Summary: ebuild-maintenance: Add news items to agenda for package moves
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Devmanual Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-18 12:11 UTC by Ulrich Müller
Modified: 2016-05-22 17:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (0001-ebuild-maintenance-Add-news-items-to-agenda-for-pack.patch,962 bytes, patch)
2016-05-18 12:13 UTC, Ulrich Müller
Details | Diff
proposed patch v2 (0001-ebuild-maintenance-Add-news-items-to-agenda-for-pack.patch,976 bytes, patch)
2016-05-19 06:08 UTC, Ulrich Müller
Details | Diff
proposed patch v3 (0001-ebuild-maintenance-Add-news-items-to-agenda-for-pack.patch,1001 bytes, patch)
2016-05-20 06:52 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2016-05-18 12:11:59 UTC
Quoting GLEP 42 (and besides, it is self-evident):
"When performing package moves, developers must also update any relevant Display-If-Installed headers in news files."
Comment 1 Ulrich Müller gentoo-dev 2016-05-18 12:13:10 UTC
Created attachment 434606 [details, diff]
proposed patch
Comment 2 Göktürk Yüksek archtester gentoo-dev 2016-05-18 20:58:20 UTC
What about saying "increment" instead of "update" for Revision to be more clear:

Update any <c>Display-If-Installed</c> headers and increment the <c>Revision</c> in <uri link="::general-concepts/news">news items</uri> referencing the package.
Comment 3 Ulrich Müller gentoo-dev 2016-05-19 06:08:13 UTC
Created attachment 434662 [details, diff]
proposed patch v2

(In reply to Göktürk Yüksek from comment #2)
> What about saying "increment" instead of "update" for Revision to be more
> clear:
> 
> Update any <c>Display-If-Installed</c> headers and increment the
> <c>Revision</c> in <uri link="::general-concepts/news">news items</uri>
> referencing the package.

Patch amended, see attachment. I have kept the parentheses though.
Comment 4 Göktürk Yüksek archtester gentoo-dev 2016-05-20 06:20:01 UTC
I also considered the references in the body text of other news items:

----
Revision: 1
Display-If-Installed: app-misc/foo

Foo is obsolete, please upgrade to app-misc/bar
----

When app-misc/bar is moved to add-admin/bar, I think the news item should be updated and revision bumped so that the users upgrade to the correct package.

However, I couldn't find a concrete example for this. What do you think? Sorry for not catching this before v2.
Comment 5 Ulrich Müller gentoo-dev 2016-05-20 06:52:15 UTC
Created attachment 434760 [details, diff]
proposed patch v3

It cannot harm if we mention it, see v3 attached.
Comment 6 Ulrich Müller gentoo-dev 2016-05-22 08:39:05 UTC
Pushed.
Comment 7 Göktürk Yüksek archtester gentoo-dev 2016-05-22 17:59:06 UTC
Sorry for not being able to ack in time and making you do all the push on top of the patches. Looks good to me.