583226 – media-tv/kodi-9999: Should depend on sys-apps/lsb-release

Bug 583226 - media-tv/kodi-9999: Should depend on sys-apps/lsb-release

Summary: media-tv/kodi-9999: Should depend on sys-apps/lsb-release

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	SpanKY

URL:	https://github.com/xbmc/xbmc/pull/9832
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-05-16 19:31 UTC by hal
Modified:	2016-05-18 19:47 UTC (History)
CC List:	2 users (show)

See Also:	http://trac.kodi.tv/ticket/16729
Package list:
Runtime testing required:	---

Attachments
kodi-9999-lsb_release.patch (kodi-9999-lsb_release.patch,331 bytes, patch) 2016-05-16 19:31 UTC, hal	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description hal 2016-05-16 19:31:39 UTC

Created attachment 434460 [details, diff]
kodi-9999-lsb_release.patch

Currently calling `/usr/lib64/kodi/kodi.bin` yields `sh: lsb_release: command not found`. Therefore we should add `sys-apps/lsb-release` to $RDEPEND.

Patch included.

Comment 1 SpanKY gentoo-dev

2016-05-17 20:36:00 UTC

we don't want to depend on lsb.  in the past, we ran sed on the script to get the right output, but upstream changed to be more dynamic/friendly.  if they regressed, then should fix them to not throw this warning/error.

a good alternative would be to support /etc/os-release as all distros are moving to that standard.

Comment 2 hal 2016-05-18 18:56:34 UTC

Gets fixed upstream: https://github.com/xbmc/xbmc/pull/9832