Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582610 - sys-boot/vboot-utils-51_p20160427 fails on armv7 with format errors (all warnings being treated as errors)
Summary: sys-boot/vboot-utils-51_p20160427 fails on armv7 with format errors (all warn...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal major (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-09 22:17 UTC by Steve Arnold
Modified: 2016-05-12 03:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fixes format conversion specifiers (vboot-utils-51_p20160427-fix-format-conversion-specifiers-for-correct-types.patch,1.99 KB, patch)
2016-05-09 22:17 UTC, Steve Arnold
Details | Diff
build log fail (vboot-utils-51_p20160427-20160509-184253.log,135.82 KB, text/plain)
2016-05-11 18:30 UTC, Steve Arnold
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Arnold archtester gentoo-dev 2016-05-09 22:17:19 UTC
Created attachment 433800 [details, diff]
fixes format conversion specifiers

Because all warnings are treated as errors by upstream, and they ship some minor format errors along with.  Here's a patch that makes it build clean again.

Portage 2.2.28 (python 2.7.11-final-0, default/linux/arm/13.0/armv7a/desktop, gcc-5.3.0, glibc-2.23-r2, 4.4.0-armv7-x3.1 armv7l)
Comment 1 SpanKY gentoo-dev 2016-05-11 18:22:05 UTC
if you want to post patches, then upstream uses gerrit.  it's a simple push away.

otherwise, please attach full build logs.
Comment 2 Steve Arnold archtester gentoo-dev 2016-05-11 18:30:48 UTC
Created attachment 433984 [details]
build log fail

Here ya go, lemme know if you need more info...
Comment 3 SpanKY gentoo-dev 2016-05-11 20:25:09 UTC
thanks, that makes things clear.  i had cleaned up -Werror control upstream to make it easier to disable, but the required ebuild change didn't make it in.  should be fixed here:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da6d0e9edc4b36790c6a61ebd1182bf1f4e88f71

if you want to pursue that patch upstream though, feel free to send it to gerrit and add me as a reviewer :).  as it stands, i don't think it's correct ... it looks like you're changing %lu to %u when it should be %zu (as it's a size_t).
Comment 4 Steve Arnold archtester gentoo-dev 2016-05-12 03:13:57 UTC
Thanks, I missed that bit (even though I was looking at it).  And the current one is %ld which is definitely not correct...