Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582340 - repoman: warn people about not adding support for latest python versions
Summary: repoman: warn people about not adding support for latest python versions
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-07 12:21 UTC by Pacho Ramos
Modified: 2022-07-12 03:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-05-07 12:21:57 UTC
I am not sure if the place for this would be in repoman or as a QA warning shown by python eclasses.

I think we should warn developers when they forget to even try to add support for newer python versions in PYTHON_COMPAT (if the package doesn't work with, for example, py3.5, the warning is still ok as that package will need to be fixed sooner or later).

Currently, it's always a headache to dig into all python reverse deps to try to make them compatible with newer python versions. And this work needs to be redone on every python release, then, seeing people still committing new ebuilds without this is... :S

Thanks
Comment 1 Pacho Ramos gentoo-dev 2017-07-15 10:22:29 UTC
At least it seems people are not against this :)
https://archives.gentoo.org/gentoo-dev/message/7e5e71d97310869c09f334722fea7d1d
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2017-07-15 15:37:45 UTC
yes, we certainly could add a repoman module to check and nag about that.

I am just about done with part1 of the stage3 rewrite.  It has split the line-checks into a plugin system as well.  So it should be easier to create a check for that.
Comment 3 Zac Medico gentoo-dev 2017-07-15 19:05:43 UTC
Parsing PYTHON_COMPAT (bash syntax) directly from the ebuild would be tricky, so we'd probably want implement this using the python_targets_* flags in IUSE.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-07-15 19:17:06 UTC
gpyutils already relies on PYTHON_COMPAT being able to be evaluated via bash sanely (but uses USE flags as speedup). USE flags won't work for python-any-r1 ebuilds.
Comment 5 Pacho Ramos gentoo-dev 2018-06-28 08:38:10 UTC
Maybe, if it's too hard to implement in repoman side, a check could be added to python-utils-r1.eclass. If the highest "impl" is not found in PYTHON_COMPAT it could show an eqawarn message :/
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-07-22 10:50:36 UTC
To be honest, I don't think adding it to the eclass is a good idea.  Many users have QA warnings enabled, so this would be very verbose way of doing it, and it will result in a lot of bugs filed.  It would become especially problematic if the newer Python version is supported in newer ~arch version but people using stable will see it nevertheless.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:21 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.