Bug 582242 – dev-util/cmake - FindQt4.cmake does not respect prefix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description gtkgfxp 2016-05-06 08:53:36 UTC]

if(CMAKE_BUILD_TYPE STREQUAL Gentoo)
    find_program(QT_QMAKE_EXECUTABLE NAMES ${QMAKE_NAME}
      PATHS
        /usr/${CMAKE_INSTALL_LIBDIR}/qt4/bin
        /usr/bin
        NO_DEFAULT_PATH
      DOC "The qmake executable for the Qt installation to use"
    )
-----
        /usr/${CMAKE_INSTALL_LIBDIR}/qt4/bin
        /usr/bin 
 =>
        ${EPREFIX_VALUE}/usr/${CMAKE_INSTALL_LIBDIR}/qt4/bin
        ${EPREFIX_VALUE}/usr/bin
in gentoo::prefix's FindQt4.cmake
-----

Reproducible: Always

Steps to Reproduce:
1.USE="X -autostart -cairo dbus -debug -enchant -gtk2 -gtk3 -introspection -lua -nls -opencc -pango qt4 -static-libs -table -xml {-test}" emerge =app-i18n/fcitx-9999
2.
3.
Actual Results:  
* QA Notice: the following files are outside of the prefix:
 * /usr
 * /usr/lib64
 * /usr/lib64/qt4
 * /usr/lib64/qt4/plugins
 * /usr/lib64/qt4/plugins/inputmethods
 * /usr/lib64/qt4/plugins/inputmethods/qtim-fcitx.so
 * ERROR: app-i18n/fcitx-9999::gentoo_prefix failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
 * 
 * Call stack:
 *   misc-functions.sh, line 1236:  Called install_qa_check
 *   misc-functions.sh, line  223:  Called source 'install_symlink_html_docs'
 *            05prefix, line  115:  Called install_qa_check_prefix
 *            05prefix, line   27:  Called die
 * The specific snippet of code:
 *   			die "Aborting due to QA concerns: there are files installed outside the prefix"

Expected Results:  
 * ${EPREFIX_VALUE}/usr/lib64/qt4/plugins
 * ${EPREFIX_VALUE}/usr/lib64/qt4/plugins/inputmethods
 * ${EPREFIX_VALUE}/usr/lib64/qt4/plugins/inputmethods/qtim-fcitx.so

[Comment 1 Davide Pesavento (RETIRED) 2016-05-08 19:49:09 UTC]

What does this have to do with qtcore? The failing package is app-i18n/fcitx and FindQt4.cmake is installed by dev-util/cmake, neither of which is maintained by the qt team.

[Comment 2 Johannes Huber (RETIRED) 2016-05-09 19:08:45 UTC]

Please attach full build log.

[Comment 3 gtkgfxp 2016-05-19 15:38:08 UTC]

Created attachment 434726 [details]
build.log

build.log

[Comment 4 gtkgfxp 2016-05-19 15:53:50 UTC]

	fixed by following?(test passed on my local machine)
	--- a/usr/share/cmake/Modules/FindQt4.cmake	2016-05-06 15:34:28.479608300 +0800
	+++ b/usr/share/cmake/Modules/FindQt4.cmake	2016-05-19 22:24:18.309789259 +0800
	@@ -485,8 +485,8 @@
	   if(CMAKE_BUILD_TYPE STREQUAL Gentoo)
		 find_program(QT_QMAKE_EXECUTABLE NAMES ${QMAKE_NAME}
		   PATHS
	-        /usr/${CMAKE_INSTALL_LIBDIR}/qt4/bin
	-        /usr/bin
	+        $ENV{EPREFIX}/usr/${CMAKE_INSTALL_LIBDIR}/qt4/bin
	+        $ENV{EPREFIX}/usr/bin
			 NO_DEFAULT_PATH
		   DOC "The qmake executable for the Qt installation to use"
		 )

[Comment 5 Fabian Groffen 2016-05-21 10:02:56 UTC]

@kde: this requires an update to files/cmake-3.3.2-FindQt4.patch.  I propose a bump of that patch, and a new revision for cmake-3.5.2.

[Comment 6 Johannes Huber (RETIRED) 2016-05-21 16:37:41 UTC]

(In reply to Fabian Groffen from comment #5)
> @kde: this requires an update to files/cmake-3.3.2-FindQt4.patch.  I propose
> a bump of that patch, and a new revision for cmake-3.5.2.

Yes same is reported against kdelibs.

[Comment 7 Michael Palimaka (kensington) 2016-05-21 18:38:01 UTC]

Thanks, fixed in git. I stuffed up the attribution in the commit, sorry about that.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aeefe0ac126a66ccdbb482cd24a035ca486aa54d

[Comment 8 Benda Xu 2016-05-22 03:45:01 UTC]

Thanks, guys. I was bitten by this bug a month ago.