Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 581410 - app-misc/inputlircd: fails to build with >=sys-kernel/linux-headers-4.4
Summary: app-misc/inputlircd: fails to build with >=sys-kernel/linux-headers-4.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 04:01 UTC by Michael Cook
Modified: 2016-04-30 11:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix linux 4.4 (inputlircd-linux-4.4-fix.patch,343 bytes, patch)
2016-04-28 04:02 UTC, Michael Cook
Details | Diff
Fixed ebuild (inputlircd-0.0.1_pre15-r2.ebuild,1.00 KB, text/plain)
2016-04-29 17:54 UTC, Michael Cook
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Cook 2016-04-28 04:01:19 UTC
inputlircd does some code generation in gennames that parses /usr/include/linux/input.h to generate a header. With 4.4 this include had the information the script wants moved into /usr/include/linux/input-event-codes.h

It still builds fine, it just doesn't work correctly since it ends up pumping unnamed codes into the lirc socket which would require manual set up if the application supported it.
Comment 1 Michael Cook 2016-04-28 04:02:55 UTC
Created attachment 432364 [details, diff]
Patch to fix linux 4.4

This patch will allow the program to function correctly with >=linux-headers-4.4, but it breaks for older version, so I'm not entirely sure what the best solution is.
Comment 2 Sam Jorna (wraeth) gentoo-dev 2016-04-29 13:31:57 UTC
Hi!

Thanks for the patch!

This package currently has no maintainer. Would you be interested in becoming
the proxy maintainer[0] for this? This would mean being responsible for bugs and
version bumps, providing patches and ebuilds as required.

In terms of how to handle this, the patch could be conditionally applied by
using `best_version`[1] to get the version of linux-headers installed and only
applying the patch if the version is greater or equal than 4.4.

You can use `qgrep -H best_version` (from app-portage/portage-utils) to find
other ebuilds that use it for examples on how this could be done.

[0] https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
[1] https://devmanual.gentoo.org/function-reference/query-functions/

Cheers!
Comment 3 Michael Cook 2016-04-29 17:54:31 UTC
Created attachment 432584 [details]
Fixed ebuild

I'm not necessarily interested in taking on the responsibility, but here is a fixed ebuild that will only apply the patch for >=sys-kernel/linux-headers-4.4. I also figured a revision bump was in order since there are probably people with broken installs.
Comment 4 Sam Jorna (wraeth) gentoo-dev 2016-04-30 11:37:41 UTC
Thanks for your contribution!

I made a few further changes to the ebuild - specifically updating it to EAPI6 and cleaning up a few other bits and pieces.


commit dfddec86a5787c2dc3633a0468d681126181d6a2
Author: Sam Jorna <wraeth@gentoo.org>
Date:   Sat Apr 30 21:32:51 2016 +1000

    app-misc/inputlircd: revbump, fix build with headers-4.4
    
    Introduces conditional patch for building against linux-headers-4.4, fixing a
    runtime issue with using unknown commands for the lirc socket. Patch and
    initial ebuild submitted by user Michael Cook, ebuild updated to EAPI6.
    
    Gentoo-bug: 581410
    Package-Manager: portage-2.2.28