Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 581338 - dev-perl/Filesys-SmbClient-3.200.0-r1 no longer works with samba-4
Summary: dev-perl/Filesys-SmbClient-3.200.0-r1 no longer works with samba-4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 09:04 UTC by Dennis Lichtenthäler
Modified: 2017-01-04 09:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to remove dependency on smbclient use flag (ebuild.patch,445 bytes, patch)
2016-04-27 09:04 UTC, Dennis Lichtenthäler
Details | Diff
patch Makefile.pl to use pkg-config (0003-Use-pkg-config-instead-of-trickery-to-find-samba-4-l.patch,970 bytes, patch)
2016-04-27 09:07 UTC, Dennis Lichtenthäler
Details | Diff
patch configure.in to reverse detection logic (0001-Reverse-close_fn-close-detection-logic.patch,205.32 KB, patch)
2016-04-27 09:08 UTC, Dennis Lichtenthäler
Details | Diff
ebuild:Remove smbclient dependency, include patches, run autoconf (ebuild.patch,803 bytes, patch)
2016-04-27 09:13 UTC, Dennis Lichtenthäler
Details | Diff
patch configure.in to reverse detection logic (samba-4-close_fn.patch,589 bytes, patch)
2016-04-27 09:14 UTC, Dennis Lichtenthäler
Details | Diff
patch Makefile.pl to use pkg-config (samba-4-pkg_config.patch,970 bytes, patch)
2016-04-27 09:14 UTC, Dennis Lichtenthäler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Lichtenthäler 2016-04-27 09:04:10 UTC
Created attachment 432240 [details, diff]
Patch to remove dependency on smbclient use flag

The package has the following problems when trying to use it with samba-4:

* It depends on a no longer existing use-flag 'smbclient' for net-fs/samba
* The Makefile.PL fails to pick up the include directory for libsmbclient.h
* The package doesn't compile due to problematic configure checks

I'll attach (rather small) patches for all three problems.
Comment 1 Dennis Lichtenthäler 2016-04-27 09:07:05 UTC
Created attachment 432242 [details, diff]
patch Makefile.pl to use pkg-config
Comment 2 Dennis Lichtenthäler 2016-04-27 09:08:07 UTC
Created attachment 432244 [details, diff]
patch configure.in to reverse detection logic

This is larger than it needs to be because I've included the pregenerated configure script. Maybe this can be generated on the fly?
Comment 3 Dennis Lichtenthäler 2016-04-27 09:13:46 UTC
Created attachment 432246 [details, diff]
ebuild:Remove smbclient dependency, include patches, run autoconf
Comment 4 Dennis Lichtenthäler 2016-04-27 09:14:28 UTC
Created attachment 432248 [details, diff]
patch configure.in to reverse detection logic
Comment 5 Dennis Lichtenthäler 2016-04-27 09:14:45 UTC
Created attachment 432250 [details, diff]
patch Makefile.pl to use pkg-config
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2017-01-04 09:59:41 UTC
commit 7e57da211cb9455800ad9963c41d1429b3606fd3 (HEAD -> master, origin/master, origin/HEAD)
Author: Andreas K. Hüttel <dilfridge@gentoo.org>
Date:   Wed Jan 4 10:57:10 2017 +0100

    dev-perl/Filesys-SmbClient: Make it build with samba-4, bug 581338
    
    Thanks to Dennis Lichtenthäler
    
    Package-Manager: Portage-2.3.3, Repoman-2.3.1

 dev-perl/Filesys-SmbClient/Filesys-SmbClient-3.200.0-r2.ebuild              | 34 ++++++++++++++++++++++++++++++++++
 dev-perl/Filesys-SmbClient/files/Filesys-SmbClient-3.200.0-close_fn.patch   | 18 ++++++++++++++++++
 dev-perl/Filesys-SmbClient/files/Filesys-SmbClient-3.200.0-pkg_config.patch | 36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 88 insertions(+)