Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 581214 - net-libs/ignition-transport-1.1.0: protobuf3.patch should be conditional
Summary: net-libs/ignition-transport-1.1.0: protobuf3.patch should be conditional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 00:53 UTC by Victor Mataré
Modified: 2016-04-30 15:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Mataré 2016-04-26 00:53:02 UTC 
the protobuf3.patch just adds a protobuf-3-specific include, which breaks builds when =protobuf-2* is installed. The include should be wrapped into a version check, something like


#if GOOGLE_PROTOBUF_VERSION >= 3000000
#include blah...
#endif
Comment 1 Alexis Ballier gentoo-dev 2016-04-30 15:21:48 UTC 
commit 295de3a6c62704f437339af9c5e3751bfa65f601
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Sat Apr 30 17:20:39 2016 +0200

    net-libs/ignition-transport: add version guards to the protobuf3 patch so that protobuf2 support still works. Bug #581214 by Victor Mataré.


thanks!