Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579460 - please make repoman ignore a missing "# $Id$" header line
Summary: please make repoman ignore a missing "# $Id$" header line
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL: https://projects.gentoo.org/council/m...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: portage-2.3.0
  Show dependency tree
 
Reported: 2016-04-09 22:21 UTC by Andreas K. Hüttel
Modified: 2017-02-26 09:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas K. Hüttel archtester gentoo-dev 2016-04-09 22:21:19 UTC
As per council decision, the CVS headers can be dropped after the git migration, 
see also $URL. 

Please make repoman ignore a missing "# $Id$" header line in ebuilds.

TIA!
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2016-05-08 19:22:01 UTC
ping
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2016-05-08 19:47:30 UTC
yes, it will be in the next release
Comment 3 Pacho Ramos gentoo-dev 2016-05-27 08:28:13 UTC
Have you think in actively dropping the line when found? I am thinking in something similar to repoman being able to update copyright line when needed. That would safe us from getting confused about whether to keep it or not. 

For example, I have seen recently in openssl ebuild the line being dropped initially but later readded... and that caused me to try to search for the policy on this because I was also wondering about what to do when I update my ebuilds :/

Thanks :)
Comment 4 Brian Dolbec (RETIRED) gentoo-dev 2016-05-27 14:28:12 UTC
This has been released in the 2.3.0_rc1 release,

commit: 4175b9b3b39aa0f502921435bdae34a74679e53b

In this commit it just ignores the $ID line, it does not drop it.
All that has been done in the code is comment out the check.  It will likely be made into a repo configuration option for repoman.

Repoman does fix the copyright line automatically again.  I don't think removing the $ID line is something that it should be doing automatically.
Comment 5 Ulrich Müller gentoo-dev 2017-02-25 14:06:26 UTC
Fixed in stable repoman-2.3.0-r1. Closing.